Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: chrome/browser/resources/options/import_data_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh just no Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/import_data_overlay.js
diff --git a/chrome/browser/resources/options/import_data_overlay.js b/chrome/browser/resources/options/import_data_overlay.js
index eef9f3deafacceb7c3de0f13f113bd0548d3865c..3afca328f4a714818ae0de16037092f0a8fbda35 100644
--- a/chrome/browser/resources/options/import_data_overlay.js
+++ b/chrome/browser/resources/options/import_data_overlay.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
/**
* ImportDataOverlay class
@@ -11,22 +12,21 @@ cr.define('options', function() {
* @class
*/
function ImportDataOverlay() {
- OptionsPage.call(this,
- 'importData',
- loadTimeData.getString('importDataOverlayTabTitle'),
- 'import-data-overlay');
+ Page.call(this,
+ 'importData',
+ loadTimeData.getString('importDataOverlayTabTitle'),
+ 'import-data-overlay');
}
cr.addSingletonGetter(ImportDataOverlay);
ImportDataOverlay.prototype = {
- // Inherit from OptionsPage.
- __proto__: OptionsPage.prototype,
+ // Inherit from Page.
+ __proto__: Page.prototype,
/** @override */
initializePage: function() {
- // Call base class implementation to start preference initialization.
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
var self = this;
var checkboxes =
@@ -240,7 +240,7 @@ cr.define('options', function() {
*/
ImportDataOverlay.dismiss = function() {
ImportDataOverlay.clearUserPrefs();
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
};
/**
@@ -262,7 +262,7 @@ cr.define('options', function() {
ImportDataOverlay.getInstance().updateSuccessState_(false);
ImportDataOverlay.getInstance().validateCommitButton_();
- OptionsPage.navigateToPage('importData');
+ PageManager.showPageByName('importData');
};
// Export

Powered by Google App Engine
This is Rietveld 408576698