Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: chrome/browser/resources/options/handler_options.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh just no Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/handler_options.js
diff --git a/chrome/browser/resources/options/handler_options.js b/chrome/browser/resources/options/handler_options.js
index 0918e0f28896f0c28268b15fbb65c3ce1e3e88ca..7ce020eebf070436ce9430e3550970534eace22a 100644
--- a/chrome/browser/resources/options/handler_options.js
+++ b/chrome/browser/resources/options/handler_options.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- /** @const */ var OptionsPage = options.OptionsPage;
+ /** @const */ var Page = cr.ui.pageManager.Page;
+ /** @const */ var PageManager = cr.ui.pageManager.PageManager;
/////////////////////////////////////////////////////////////////////////////
// HandlerOptions class:
@@ -14,16 +15,16 @@ cr.define('options', function() {
*/
function HandlerOptions() {
this.activeNavTab = null;
- OptionsPage.call(this,
- 'handlers',
- loadTimeData.getString('handlersPageTabTitle'),
- 'handler-options');
+ Page.call(this,
+ 'handlers',
+ loadTimeData.getString('handlersPageTabTitle'),
+ 'handler-options');
}
cr.addSingletonGetter(HandlerOptions);
HandlerOptions.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/**
* The handlers list.
@@ -34,12 +35,12 @@ cr.define('options', function() {
/** @override */
initializePage: function() {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
this.createHandlersList_();
$('handler-options-overlay-confirm').onclick =
- OptionsPage.closeOverlay.bind(OptionsPage);
+ PageManager.closeOverlay.bind(PageManager);
},
/**
« no previous file with comments | « chrome/browser/resources/options/geolocation_options.js ('k') | chrome/browser/resources/options/home_page_overlay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698