Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: chrome/browser/resources/options/content_settings_exceptions_area.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh just no Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/content_settings_exceptions_area.js
diff --git a/chrome/browser/resources/options/content_settings_exceptions_area.js b/chrome/browser/resources/options/content_settings_exceptions_area.js
index 5d25d728892e4b7a8d0211563911d67fc7838432..b1b14a1c091a1920bc15e81488a3002f8d9bda8d 100644
--- a/chrome/browser/resources/options/content_settings_exceptions_area.js
+++ b/chrome/browser/resources/options/content_settings_exceptions_area.js
@@ -589,7 +589,8 @@ cr.define('options.contentSettings', function() {
},
};
- var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
/**
* Encapsulated handling of content settings list subpage.
@@ -597,19 +598,19 @@ cr.define('options.contentSettings', function() {
* @constructor
*/
function ContentSettingsExceptionsArea() {
- OptionsPage.call(this, 'contentExceptions',
- loadTimeData.getString('contentSettingsPageTabTitle'),
- 'content-settings-exceptions-area');
+ Page.call(this, 'contentExceptions',
+ loadTimeData.getString('contentSettingsPageTabTitle'),
+ 'content-settings-exceptions-area');
}
cr.addSingletonGetter(ContentSettingsExceptionsArea);
ContentSettingsExceptionsArea.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/** @override */
initializePage: function() {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
var exceptionsLists = this.pageDiv.querySelectorAll('list');
for (var i = 0; i < exceptionsLists.length; i++) {
@@ -622,7 +623,7 @@ cr.define('options.contentSettings', function() {
this.showList('cookies');
$('content-settings-exceptions-overlay-confirm').onclick =
- OptionsPage.closeOverlay.bind(OptionsPage);
+ PageManager.closeOverlay.bind(PageManager);
},
/**
« no previous file with comments | « chrome/browser/resources/options/content_settings.js ('k') | chrome/browser/resources/options/controlled_setting.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698