Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3050)

Unified Diff: chrome/browser/resources/options/content_settings.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh just no Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/content_settings.js
diff --git a/chrome/browser/resources/options/content_settings.js b/chrome/browser/resources/options/content_settings.js
index 68b449d84129969b936a20cf76d188972e56d677..e751f7d5b2ab1645ab95553062ebe1aa4a412e3a 100644
--- a/chrome/browser/resources/options/content_settings.js
+++ b/chrome/browser/resources/options/content_settings.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- /** @const */ var OptionsPage = options.OptionsPage;
+ /** @const */ var Page = cr.ui.pageManager.Page;
+ /** @const */ var PageManager = cr.ui.pageManager.PageManager;
//////////////////////////////////////////////////////////////////////////////
// ContentSettings class:
@@ -14,19 +15,19 @@ cr.define('options', function() {
*/
function ContentSettings() {
this.activeNavTab = null;
- OptionsPage.call(this, 'content',
- loadTimeData.getString('contentSettingsPageTabTitle'),
- 'content-settings-page');
+ Page.call(this, 'content',
+ loadTimeData.getString('contentSettingsPageTabTitle'),
+ 'content-settings-page');
}
cr.addSingletonGetter(ContentSettings);
ContentSettings.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/** @override */
initializePage: function() {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
var exceptionsButtons =
this.pageDiv.querySelectorAll('.exceptions-list-button');
@@ -42,14 +43,14 @@ cr.define('options', function() {
// Navigate after the local history has been replaced in order to have
// the correct hash loaded.
- OptionsPage.showPageByName('contentExceptions', false);
+ PageManager.showPageByName('contentExceptions', false);
};
}
var manageHandlersButton = $('manage-handlers-button');
if (manageHandlersButton) {
manageHandlersButton.onclick = function(event) {
- OptionsPage.navigateToPage('handlers');
+ PageManager.showPageByName('handlers');
};
}
@@ -64,11 +65,11 @@ cr.define('options', function() {
// Cookies filter page ---------------------------------------------------
$('show-cookies-button').onclick = function(event) {
chrome.send('coreOptionsUserMetricsAction', ['Options_ShowCookies']);
- OptionsPage.navigateToPage('cookies');
+ PageManager.showPageByName('cookies');
};
$('content-settings-overlay-confirm').onclick =
- OptionsPage.closeOverlay.bind(OptionsPage);
+ PageManager.closeOverlay.bind(PageManager);
$('media-pepper-flash-default').hidden = true;
$('media-pepper-flash-exceptions').hidden = true;
@@ -145,7 +146,7 @@ cr.define('options', function() {
if (mediaSettings.cameraDisabled)
$('media-select-camera').disabled = true;
- OptionsPage.hideBubble();
+ PageManager.hideBubble();
// Create a synthetic pref change event decorated as
// CoreOptionsHandler::CreateValueForPref() does.
// TODO(arv): It was not clear what event type this should use?

Powered by Google App Engine
This is Rietveld 408576698