Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1547)

Unified Diff: chrome/browser/resources/options/chromeos/network_list.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh just no Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/network_list.js
diff --git a/chrome/browser/resources/options/chromeos/network_list.js b/chrome/browser/resources/options/chromeos/network_list.js
index 8a1ae1d3cef6b5f79681d9e64f5e7a6bef032fdb..a0b45b5f64b36adff37bdcb0808ef0c2ace6359e 100644
--- a/chrome/browser/resources/options/chromeos/network_list.js
+++ b/chrome/browser/resources/options/chromeos/network_list.js
@@ -3,7 +3,6 @@
// found in the LICENSE file.
cr.define('options.network', function() {
-
var ArrayDataModel = cr.ui.ArrayDataModel;
var List = cr.ui.List;
var ListItem = cr.ui.ListItem;
@@ -367,8 +366,9 @@ cr.define('options.network', function() {
/**
* Creates a control for selecting or configuring a network connection based
* on the type of connection (e.g. wifi versus vpn).
- * @param {{key: string,
- * networkList: Array.<Object>} data Description of the network.
+ * @param {Object} data Description of the network.
+ * @param {string} data.key Item key.
+ * @param {Array.<Object>} data.networkList Description of the network.
* @constructor
*/
function NetworkSelectorItem(data) {
@@ -479,7 +479,7 @@ cr.define('options.network', function() {
var callback = function(list) {
$('remembered-network-list').clear();
var dialog = options.PreferredNetworks.getInstance();
- OptionsPage.showPageByName('preferredNetworksPage', false);
+ PageManager.showPageByName('preferredNetworksPage', false);
dialog.update(list);
chrome.send('coreOptionsUserMetricsAction',
['Options_NetworkShowPreferred']);
@@ -658,9 +658,10 @@ cr.define('options.network', function() {
/**
* Creates a button-like control for configurating internet connectivity.
- * @param {{key: string,
- * subtitle: string,
- * command: function} data Description of the network control.
+ * @param {Object} data Description of the network control.
+ * @param {string} data.key Item key.
+ * @param {string} data.subtitle Subtitle.
+ * @param {function} data.command Item callback.
* @constructor
*/
function NetworkButtonItem(data) {
@@ -808,7 +809,7 @@ cr.define('options.network', function() {
* @private
*/
onSelectionChange_: function(event) {
- OptionsPage.hideBubble();
+ PageManager.hideBubble();
// A list item may temporarily become unselected while it is constructing
// its menu. The menu should therefore only be closed if a different item
// is selected, not when the menu's owner item is deselected.
@@ -1063,7 +1064,7 @@ cr.define('options.network', function() {
closeMenu_();
ControlledSettingIndicator.prototype.toggleBubble_.call(this);
if (this.showingBubble) {
- var bubble = OptionsPage.getVisibleBubble();
+ var bubble = PageManager.getVisibleBubble();
bubble.addEventListener('mousedown', this.stopEvent);
bubble.addEventListener('click', this.stopEvent);
}

Powered by Google App Engine
This is Rietveld 408576698