Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2399)

Unified Diff: chrome/browser/resources/options/certificate_backup_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh just no Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/certificate_backup_overlay.js
diff --git a/chrome/browser/resources/options/certificate_backup_overlay.js b/chrome/browser/resources/options/certificate_backup_overlay.js
index ddc276e7e1d2e84d67f531704bd90183ccc13470..9c516b0f2a83412b52796647b67fff2bc1fa4ed5 100644
--- a/chrome/browser/resources/options/certificate_backup_overlay.js
+++ b/chrome/browser/resources/options/certificate_backup_overlay.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- /** @const */ var OptionsPage = options.OptionsPage;
+ /** @const */ var Page = cr.ui.pageManager.Page;
+ /** @const */ var PageManager = cr.ui.pageManager.PageManager;
/**
* CertificateBackupOverlay class
@@ -11,19 +12,17 @@ cr.define('options', function() {
* @class
*/
function CertificateBackupOverlay() {
- OptionsPage.call(this, 'certificateBackupOverlay',
- '',
- 'certificateBackupOverlay');
+ Page.call(this, 'certificateBackupOverlay', '', 'certificateBackupOverlay');
}
cr.addSingletonGetter(CertificateBackupOverlay);
CertificateBackupOverlay.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/** @override */
initializePage: function() {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
var self = this;
$('certificateBackupCancelButton').onclick = function(event) {
@@ -47,7 +46,7 @@ cr.define('options', function() {
*/
dismissOverlay_: function() {
this.clearInputFields_();
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
},
/**
@@ -101,7 +100,7 @@ cr.define('options', function() {
CertificateBackupOverlay.show = function() {
CertificateBackupOverlay.getInstance().clearInputFields_();
- OptionsPage.navigateToPage('certificateBackupOverlay');
+ PageManager.showPageByName('certificateBackupOverlay');
};
CertificateBackupOverlay.dismiss = function() {

Powered by Google App Engine
This is Rietveld 408576698