Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/browser/resources/options/website_settings.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/website_settings.js
diff --git a/chrome/browser/resources/options/website_settings.js b/chrome/browser/resources/options/website_settings.js
index 9e532d73891e2432e54a900efdcb23bd92a64fbf..ede11bd609faed5517b6abec1a08b24b4380240a 100644
--- a/chrome/browser/resources/options/website_settings.js
+++ b/chrome/browser/resources/options/website_settings.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- /** @const */ var OptionsPage = options.OptionsPage;
+ /** @const */ var Page = cr.ui.pageManager.Page;
+ /** @const */ var PageManager = cr.ui.pageManager.PageManager;
/** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
/////////////////////////////////////////////////////////////////////////////
@@ -14,15 +15,15 @@ cr.define('options', function() {
* @constructor
*/
function WebsiteSettingsManager() {
- OptionsPage.call(this, 'websiteSettings',
- loadTimeData.getString('websitesOptionsPageTabTitle'),
- 'website-settings-page');
+ Page.call(this, 'websiteSettings',
+ loadTimeData.getString('websitesOptionsPageTabTitle'),
+ 'website-settings-page');
}
cr.addSingletonGetter(WebsiteSettingsManager);
WebsiteSettingsManager.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/**
* The saved origins list.
@@ -33,10 +34,10 @@ cr.define('options', function() {
/** @override */
initializePage: function() {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
$('website-settings-overlay-confirm').onclick =
- OptionsPage.closeOverlay.bind(OptionsPage);
+ PageManager.closeOverlay.bind(PageManager);
$('resourceType').onchange = function() {
var target = event.target;

Powered by Google App Engine
This is Rietveld 408576698