Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: chrome/browser/resources/options/search_engine_manager.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/search_engine_manager.js
diff --git a/chrome/browser/resources/options/search_engine_manager.js b/chrome/browser/resources/options/search_engine_manager.js
index 7d8df03c1aea5d5f1aa8e7b53e842b33b5bedde0..2f5146041f0e3506fe2636ccfe40435f471507a1 100644
--- a/chrome/browser/resources/options/search_engine_manager.js
+++ b/chrome/browser/resources/options/search_engine_manager.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- /** @const */ var OptionsPage = options.OptionsPage;
+ /** @const */ var Page = cr.ui.pageManager.Page;
+ /** @const */ var PageManager = cr.ui.pageManager.PageManager;
/** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
/**
@@ -12,15 +13,15 @@ cr.define('options', function() {
*/
function SearchEngineManager() {
this.activeNavTab = null;
- OptionsPage.call(this, 'searchEngines',
- loadTimeData.getString('searchEngineManagerPageTabTitle'),
- 'search-engine-manager-page');
+ Page.call(this, 'searchEngines',
+ loadTimeData.getString('searchEngineManagerPageTabTitle'),
+ 'search-engine-manager-page');
}
cr.addSingletonGetter(SearchEngineManager);
SearchEngineManager.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/**
* List for default search engine options.
@@ -42,7 +43,7 @@ cr.define('options', function() {
/** inheritDoc */
initializePage: function() {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
this.defaultsList_ = $('default-search-engine-list');
this.setUpList_(this.defaultsList_);
@@ -54,7 +55,7 @@ cr.define('options', function() {
this.setUpList_(this.extensionList_);
$('search-engine-manager-confirm').onclick = function() {
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
};
},

Powered by Google App Engine
This is Rietveld 408576698