Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3014)

Unified Diff: chrome/browser/resources/options/managed_user_import.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/managed_user_import.js
diff --git a/chrome/browser/resources/options/managed_user_import.js b/chrome/browser/resources/options/managed_user_import.js
index f37e2209598b70661839879d920cc19547cbc0c7..1c203451d814912e138fe20e4ea6f4000fc387bc 100644
--- a/chrome/browser/resources/options/managed_user_import.js
+++ b/chrome/browser/resources/options/managed_user_import.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
var ArrayDataModel = cr.ui.ArrayDataModel;
/**
@@ -14,15 +15,15 @@ cr.define('options', function() {
*/
function ManagedUserImportOverlay() {
var title = loadTimeData.getString('managedUserImportTitle');
- OptionsPage.call(this, 'managedUserImport',
- title, 'managed-user-import');
+ Page.call(this, 'managedUserImport',
+ title, 'managed-user-import');
};
cr.addSingletonGetter(ManagedUserImportOverlay);
ManagedUserImportOverlay.prototype = {
- // Inherit from OptionsPage.
- __proto__: OptionsPage.prototype,
+ // Inherit from Page.
+ __proto__: Page.prototype,
/** @override */
canShowPage: function() {
@@ -33,8 +34,7 @@ cr.define('options', function() {
* Initialize the page.
*/
initializePage: function() {
- // Call base class implementation to start preference initialization.
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
var managedUserList = $('managed-user-list');
options.managedUserOptions.ManagedUserList.decorate(managedUserList);
@@ -61,7 +61,7 @@ cr.define('options', function() {
// 'cancelCreateProfile' is handled by CreateProfileHandler.
chrome.send('cancelCreateProfile');
}
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
};
$('managed-user-import-ok').onclick =
@@ -232,7 +232,7 @@ cr.define('options', function() {
onSuccess_: function() {
this.updateImportInProgress_(false);
options.ManagedUserListData.resetPromise();
- OptionsPage.closeAllOverlays();
+ PageManager.closeAllOverlays();
},
};

Powered by Google App Engine
This is Rietveld 408576698