Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1825)

Unified Diff: chrome/browser/resources/options/chromeos/network_list.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/network_list.js
diff --git a/chrome/browser/resources/options/chromeos/network_list.js b/chrome/browser/resources/options/chromeos/network_list.js
index 8a1ae1d3cef6b5f79681d9e64f5e7a6bef032fdb..5bbd8054f2e8e3c9ca848e0cedfe75d0fce07470 100644
--- a/chrome/browser/resources/options/chromeos/network_list.js
+++ b/chrome/browser/resources/options/chromeos/network_list.js
@@ -479,7 +479,7 @@ cr.define('options.network', function() {
var callback = function(list) {
$('remembered-network-list').clear();
var dialog = options.PreferredNetworks.getInstance();
- OptionsPage.showPageByName('preferredNetworksPage', false);
+ PageManager.showPageByName('preferredNetworksPage', false);
dialog.update(list);
chrome.send('coreOptionsUserMetricsAction',
['Options_NetworkShowPreferred']);
@@ -808,7 +808,7 @@ cr.define('options.network', function() {
* @private
*/
onSelectionChange_: function(event) {
- OptionsPage.hideBubble();
+ PageManager.hideBubble();
// A list item may temporarily become unselected while it is constructing
// its menu. The menu should therefore only be closed if a different item
// is selected, not when the menu's owner item is deselected.
@@ -1063,7 +1063,7 @@ cr.define('options.network', function() {
closeMenu_();
ControlledSettingIndicator.prototype.toggleBubble_.call(this);
if (this.showingBubble) {
- var bubble = OptionsPage.getVisibleBubble();
+ var bubble = PageManager.getVisibleBubble();
bubble.addEventListener('mousedown', this.stopEvent);
bubble.addEventListener('click', this.stopEvent);
}

Powered by Google App Engine
This is Rietveld 408576698