Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2788)

Unified Diff: chrome/browser/resources/options/chromeos/display_overscan.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/display_overscan.js
diff --git a/chrome/browser/resources/options/chromeos/display_overscan.js b/chrome/browser/resources/options/chromeos/display_overscan.js
index 0060d6cd6ff036303862c89a7581fdcbbf0614fc..b130c5a4cdfaed21974ef8d0c857b8ea3b860605 100644
--- a/chrome/browser/resources/options/chromeos/display_overscan.js
+++ b/chrome/browser/resources/options/chromeos/display_overscan.js
@@ -3,22 +3,23 @@
// found in the LICENSE file.
cr.define('options', function() {
- var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
/**
* Encapsulated handling of the 'DisplayOverscan' page.
* @constructor
*/
function DisplayOverscan() {
- OptionsPage.call(this, 'displayOverscan',
- loadTimeData.getString('displayOverscanPageTabTitle'),
- 'display-overscan-page');
+ Page.call(this, 'displayOverscan',
+ loadTimeData.getString('displayOverscanPageTabTitle'),
+ 'display-overscan-page');
}
cr.addSingletonGetter(DisplayOverscan);
DisplayOverscan.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/**
* The ID of the target display.
@@ -36,7 +37,7 @@ cr.define('options', function() {
* Initialize the page.
*/
initializePage: function() {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
this.keyHandler_ = this.handleKeyevent_.bind(this);
$('display-overscan-operation-reset').onclick = function() {
@@ -44,10 +45,10 @@ cr.define('options', function() {
};
$('display-overscan-operation-ok').onclick = function() {
chrome.send('commit');
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
};
$('display-overscan-operation-cancel').onclick = function() {
- OptionsPage.cancelOverlay();
+ PageManager.cancelOverlay();
};
},
@@ -55,13 +56,13 @@ cr.define('options', function() {
handleCancel: function() {
// signals the cancel event.
chrome.send('cancel');
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
},
/** @override */
didShowPage: function() {
if (this.id_ == null) {
- OptionsPage.cancelOverlay();
+ PageManager.cancelOverlay();
return;
}
@@ -97,8 +98,8 @@ cr.define('options', function() {
* @private
*/
onOverscanCanceled_: function() {
- if (OptionsPage.getTopmostVisiblePage() == this)
- OptionsPage.cancelOverlay();
+ if (PageManager.getTopmostVisiblePage() == this)
+ PageManager.cancelOverlay();
},
/**

Powered by Google App Engine
This is Rietveld 408576698