Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2899)

Unified Diff: chrome/browser/resources/options/chromeos/display_options.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/display_options.js
diff --git a/chrome/browser/resources/options/chromeos/display_options.js b/chrome/browser/resources/options/chromeos/display_options.js
index e0285c26fd45887e75bd23ca0ebe7914fb277a9e..b31614de553e50d9274643dbe879c577148af05d 100644
--- a/chrome/browser/resources/options/chromeos/display_options.js
+++ b/chrome/browser/resources/options/chromeos/display_options.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
// The scale ratio of the display rectangle to its original size.
/** @const */ var VISUAL_SCALE = 1 / 10;
@@ -75,15 +76,15 @@ cr.define('options', function() {
* @constructor
*/
function DisplayOptions() {
- OptionsPage.call(this, 'display',
- loadTimeData.getString('displayOptionsPageTabTitle'),
- 'display-options-page');
+ Page.call(this, 'display',
+ loadTimeData.getString('displayOptionsPageTabTitle'),
+ 'display-options-page');
}
cr.addSingletonGetter(DisplayOptions);
DisplayOptions.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/**
* Whether the current output status is mirroring displays or not.
@@ -148,7 +149,7 @@ cr.define('options', function() {
* Initialize the page.
*/
initializePage: function() {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
$('display-options-toggle-mirroring').onclick = function() {
this.mirroring_ = !this.mirroring_;
@@ -187,7 +188,7 @@ cr.define('options', function() {
// we do not care back/forward.
var displayOverscan = options.DisplayOverscan.getInstance();
displayOverscan.setDisplayId(this.displays_[this.focusedIndex_].id);
- OptionsPage.navigateToPage('displayOverscan');
+ PageManager.showPageByName('displayOverscan');
chrome.send('coreOptionsUserMetricsAction',
['Options_DisplaySetOverscan']);
}.bind(this);
@@ -208,7 +209,7 @@ cr.define('options', function() {
/** @override */
onVisibilityChanged_: function() {
- OptionsPage.prototype.onVisibilityChanged_(this);
+ Page.prototype.onVisibilityChanged_(this);
if (this.visible)
chrome.send('getDisplayInfo');
},

Powered by Google App Engine
This is Rietveld 408576698