Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: chrome/browser/resources/options/geolocation_options.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/PageTree/PageManager/, s/pageHelper/pageManager/ Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 var OptionsPage = options.OptionsPage; 6 var Page = cr.ui.pageManager.Page;
7 7
8 /** 8 /**
9 * GeolocationOptions class 9 * GeolocationOptions class
10 * Handles initialization of the geolocation options. 10 * Handles initialization of the geolocation options.
11 * @constructor 11 * @constructor
12 * @class 12 * @class
13 */ 13 */
14 function GeolocationOptions() { 14 function GeolocationOptions() {
15 OptionsPage.call(this, 15 Page.call(this,
16 'geolocationOptions', 16 'geolocationOptions',
17 loadTimeData.getString('geolocationOptionsPageTabTitle'), 17 loadTimeData.getString('geolocationOptionsPageTabTitle'),
18 'geolocationCheckbox'); 18 'geolocationCheckbox');
19 }; 19 };
20 20
21 cr.addSingletonGetter(GeolocationOptions); 21 cr.addSingletonGetter(GeolocationOptions);
22 22
23 GeolocationOptions.prototype = { 23 GeolocationOptions.prototype = {
24 __proto__: OptionsPage.prototype 24 __proto__: Page.prototype
25 }; 25 };
26 26
27 // TODO(robliao): Determine if a full unroll is necessary 27 // TODO(robliao): Determine if a full unroll is necessary
28 // (http://crbug.com/306613). 28 // (http://crbug.com/306613).
29 GeolocationOptions.showGeolocationOption = function() {}; 29 GeolocationOptions.showGeolocationOption = function() {};
30 30
31 return { 31 return {
32 GeolocationOptions: GeolocationOptions 32 GeolocationOptions: GeolocationOptions
33 }; 33 };
34 }); 34 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698