Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/browser/resources/options/language_add_language_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh just no Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /////////////////////////////////////////////////////////////////////////////// 5 ///////////////////////////////////////////////////////////////////////////////
6 // AddLanguageOverlay class: 6 // AddLanguageOverlay class:
7 7
8 cr.define('options', function() { 8 cr.define('options', function() {
9 /** @const */ var OptionsPage = options.OptionsPage; 9 /** @const */ var Page = cr.ui.pageManager.Page;
10 /** @const */ var PageManager = cr.ui.pageManager.PageManager;
10 11
11 /** 12 /**
12 * Encapsulated handling of ChromeOS add language overlay page. 13 * Encapsulated handling of ChromeOS add language overlay page.
13 * @constructor 14 * @constructor
14 */ 15 */
15 function AddLanguageOverlay() { 16 function AddLanguageOverlay() {
16 OptionsPage.call(this, 'addLanguage', 17 Page.call(this, 'addLanguage',
17 loadTimeData.getString('addButton'), 18 loadTimeData.getString('addButton'),
18 'add-language-overlay-page'); 19 'add-language-overlay-page');
19 } 20 }
20 21
21 cr.addSingletonGetter(AddLanguageOverlay); 22 cr.addSingletonGetter(AddLanguageOverlay);
22 23
23 AddLanguageOverlay.prototype = { 24 AddLanguageOverlay.prototype = {
24 // Inherit AddLanguageOverlay from OptionsPage. 25 // Inherit AddLanguageOverlay from Page.
25 __proto__: OptionsPage.prototype, 26 __proto__: Page.prototype,
26 27
27 /** @override */ 28 /** @override */
28 initializePage: function() { 29 initializePage: function() {
29 // Call base class implementation to starts preference initialization. 30 Page.prototype.initializePage.call(this);
30 OptionsPage.prototype.initializePage.call(this);
31 31
32 // Set up the cancel button. 32 // Set up the cancel button.
33 $('add-language-overlay-cancel-button').onclick = function(e) { 33 $('add-language-overlay-cancel-button').onclick = function(e) {
34 OptionsPage.closeOverlay(); 34 PageManager.closeOverlay();
35 }; 35 };
36 36
37 // Create the language list with which users can add a language. 37 // Create the language list with which users can add a language.
38 var addLanguageList = $('add-language-overlay-language-list'); 38 var addLanguageList = $('add-language-overlay-language-list');
39 var languageListData = loadTimeData.getValue('languageList'); 39 var languageListData = loadTimeData.getValue('languageList');
40 for (var i = 0; i < languageListData.length; i++) { 40 for (var i = 0; i < languageListData.length; i++) {
41 var language = languageListData[i]; 41 var language = languageListData[i];
42 var displayText = language.displayName; 42 var displayText = language.displayName;
43 // If the native name is different, add it. 43 // If the native name is different, add it.
44 if (language.displayName != language.nativeDisplayName) 44 if (language.displayName != language.nativeDisplayName)
45 displayText += ' - ' + language.nativeDisplayName; 45 displayText += ' - ' + language.nativeDisplayName;
46 46
47 var option = cr.doc.createElement('option'); 47 var option = cr.doc.createElement('option');
48 option.value = language.code; 48 option.value = language.code;
49 option.textContent = displayText; 49 option.textContent = displayText;
50 addLanguageList.appendChild(option); 50 addLanguageList.appendChild(option);
51 } 51 }
52 }, 52 },
53 }; 53 };
54 54
55 return { 55 return {
56 AddLanguageOverlay: AddLanguageOverlay 56 AddLanguageOverlay: AddLanguageOverlay
57 }; 57 };
58 }); 58 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698