Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: chrome/browser/resources/options/chromeos/keyboard_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh just no Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 6
7 /** 7 /**
8 * Auto-repeat delays (in ms) for the corresponding slider values, from 8 * Auto-repeat delays (in ms) for the corresponding slider values, from
9 * long to short. The values were chosen to provide a large range while giving 9 * long to short. The values were chosen to provide a large range while giving
10 * several options near the defaults. 10 * several options near the defaults.
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 autoRepeatDelayRange.customPrefChangeHandler = 53 autoRepeatDelayRange.customPrefChangeHandler =
54 this.handleAutoRepeatDelayPrefChange_.bind(this); 54 this.handleAutoRepeatDelayPrefChange_.bind(this);
55 55
56 var autoRepeatIntervalRange = $('auto-repeat-interval-range'); 56 var autoRepeatIntervalRange = $('auto-repeat-interval-range');
57 autoRepeatIntervalRange.valueMap = AUTO_REPEAT_INTERVALS; 57 autoRepeatIntervalRange.valueMap = AUTO_REPEAT_INTERVALS;
58 autoRepeatIntervalRange.max = AUTO_REPEAT_INTERVALS.length - 1; 58 autoRepeatIntervalRange.max = AUTO_REPEAT_INTERVALS.length - 1;
59 autoRepeatIntervalRange.customPrefChangeHandler = 59 autoRepeatIntervalRange.customPrefChangeHandler =
60 this.handleAutoRepeatIntervalPrefChange_.bind(this); 60 this.handleAutoRepeatIntervalPrefChange_.bind(this);
61 61
62 $('languages-and-input-settings').onclick = function(e) { 62 $('languages-and-input-settings').onclick = function(e) {
63 OptionsPage.navigateToPage('languages'); 63 PageManager.showPageByName('languages');
64 chrome.send('coreOptionsUserMetricsAction', 64 chrome.send('coreOptionsUserMetricsAction',
65 ['Options_KeyboardShowLanguageSettings']); 65 ['Options_KeyboardShowLanguageSettings']);
66 }; 66 };
67 67
68 $('keyboard-shortcuts').onclick = function(e) { 68 $('keyboard-shortcuts').onclick = function(e) {
69 chrome.send('showKeyboardShortcuts'); 69 chrome.send('showKeyboardShortcuts');
70 chrome.send('coreOptionsUserMetricsAction', 70 chrome.send('coreOptionsUserMetricsAction',
71 ['Options_KeyboardShowKeyboardShortcuts']); 71 ['Options_KeyboardShowKeyboardShortcuts']);
72 }; 72 };
73 }, 73 },
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 var instance = KeyboardOverlay.getInstance(); 168 var instance = KeyboardOverlay.getInstance();
169 return instance[name + '_'].apply(instance, arguments); 169 return instance[name + '_'].apply(instance, arguments);
170 }; 170 };
171 }); 171 });
172 172
173 // Export 173 // Export
174 return { 174 return {
175 KeyboardOverlay: KeyboardOverlay 175 KeyboardOverlay: KeyboardOverlay
176 }; 176 };
177 }); 177 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698