Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Side by Side Diff: chrome/browser/resources/options/language_add_language_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /////////////////////////////////////////////////////////////////////////////// 5 ///////////////////////////////////////////////////////////////////////////////
6 // AddLanguageOverlay class: 6 // AddLanguageOverlay class:
7 7
8 cr.define('options', function() { 8 cr.define('options', function() {
9 /** @const */ var OptionsPage = options.OptionsPage; 9 /** @const */ var Page = cr.ui.pageManager.Page;
10 /** @const */ var PageManager = cr.ui.pageManager.PageManager;
10 11
11 /** 12 /**
12 * Encapsulated handling of ChromeOS add language overlay page. 13 * Encapsulated handling of ChromeOS add language overlay page.
13 * @constructor 14 * @constructor
14 */ 15 */
15 function AddLanguageOverlay() { 16 function AddLanguageOverlay() {
16 OptionsPage.call(this, 'addLanguage', 17 Page.call(this, 'addLanguage',
17 loadTimeData.getString('addButton'), 18 loadTimeData.getString('addButton'),
18 'add-language-overlay-page'); 19 'add-language-overlay-page');
19 } 20 }
20 21
21 cr.addSingletonGetter(AddLanguageOverlay); 22 cr.addSingletonGetter(AddLanguageOverlay);
22 23
23 AddLanguageOverlay.prototype = { 24 AddLanguageOverlay.prototype = {
24 // Inherit AddLanguageOverlay from OptionsPage. 25 // Inherit AddLanguageOverlay from Page.
25 __proto__: OptionsPage.prototype, 26 __proto__: Page.prototype,
26 27
27 /** 28 /**
28 * Initializes AddLanguageOverlay page. 29 * Initializes AddLanguageOverlay page.
29 * Calls base class implementation to starts preference initialization.
30 */ 30 */
31 initializePage: function() { 31 initializePage: function() {
32 // Call base class implementation to starts preference initialization. 32 Page.prototype.initializePage.call(this);
33 OptionsPage.prototype.initializePage.call(this);
34 33
35 // Set up the cancel button. 34 // Set up the cancel button.
36 $('add-language-overlay-cancel-button').onclick = function(e) { 35 $('add-language-overlay-cancel-button').onclick = function(e) {
37 OptionsPage.closeOverlay(); 36 PageManager.closeOverlay();
38 }; 37 };
39 38
40 // Create the language list with which users can add a language. 39 // Create the language list with which users can add a language.
41 var addLanguageList = $('add-language-overlay-language-list'); 40 var addLanguageList = $('add-language-overlay-language-list');
42 var languageListData = loadTimeData.getValue('languageList'); 41 var languageListData = loadTimeData.getValue('languageList');
43 for (var i = 0; i < languageListData.length; i++) { 42 for (var i = 0; i < languageListData.length; i++) {
44 var language = languageListData[i]; 43 var language = languageListData[i];
45 var displayText = language.displayName; 44 var displayText = language.displayName;
46 // If the native name is different, add it. 45 // If the native name is different, add it.
47 if (language.displayName != language.nativeDisplayName) 46 if (language.displayName != language.nativeDisplayName)
48 displayText += ' - ' + language.nativeDisplayName; 47 displayText += ' - ' + language.nativeDisplayName;
49 48
50 var option = cr.doc.createElement('option'); 49 var option = cr.doc.createElement('option');
51 option.value = language.code; 50 option.value = language.code;
52 option.textContent = displayText; 51 option.textContent = displayText;
53 addLanguageList.appendChild(option); 52 addLanguageList.appendChild(option);
54 } 53 }
55 }, 54 },
56 }; 55 };
57 56
58 return { 57 return {
59 AddLanguageOverlay: AddLanguageOverlay 58 AddLanguageOverlay: AddLanguageOverlay
60 }; 59 };
61 }); 60 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698