Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: chrome/browser/resources/options/chromeos/keyboard_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 6
7 /** 7 /**
8 * Auto-repeat delays (in ms) for the corresponding slider values, from 8 * Auto-repeat delays (in ms) for the corresponding slider values, from
9 * long to short. The values were chosen to provide a large range while giving 9 * long to short. The values were chosen to provide a large range while giving
10 * several options near the defaults. 10 * several options near the defaults.
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 autoRepeatDelayRange.customPrefChangeHandler = 55 autoRepeatDelayRange.customPrefChangeHandler =
56 this.handleAutoRepeatDelayPrefChange_.bind(this); 56 this.handleAutoRepeatDelayPrefChange_.bind(this);
57 57
58 var autoRepeatIntervalRange = $('auto-repeat-interval-range'); 58 var autoRepeatIntervalRange = $('auto-repeat-interval-range');
59 autoRepeatIntervalRange.valueMap = AUTO_REPEAT_INTERVALS; 59 autoRepeatIntervalRange.valueMap = AUTO_REPEAT_INTERVALS;
60 autoRepeatIntervalRange.max = AUTO_REPEAT_INTERVALS.length - 1; 60 autoRepeatIntervalRange.max = AUTO_REPEAT_INTERVALS.length - 1;
61 autoRepeatIntervalRange.customPrefChangeHandler = 61 autoRepeatIntervalRange.customPrefChangeHandler =
62 this.handleAutoRepeatIntervalPrefChange_.bind(this); 62 this.handleAutoRepeatIntervalPrefChange_.bind(this);
63 63
64 $('languages-and-input-settings').onclick = function(e) { 64 $('languages-and-input-settings').onclick = function(e) {
65 OptionsPage.navigateToPage('languages'); 65 PageManager.showPageByName('languages');
66 chrome.send('coreOptionsUserMetricsAction', 66 chrome.send('coreOptionsUserMetricsAction',
67 ['Options_KeyboardShowLanguageSettings']); 67 ['Options_KeyboardShowLanguageSettings']);
68 }; 68 };
69 69
70 $('keyboard-shortcuts').onclick = function(e) { 70 $('keyboard-shortcuts').onclick = function(e) {
71 chrome.send('showKeyboardShortcuts'); 71 chrome.send('showKeyboardShortcuts');
72 chrome.send('coreOptionsUserMetricsAction', 72 chrome.send('coreOptionsUserMetricsAction',
73 ['Options_KeyboardShowKeyboardShortcuts']); 73 ['Options_KeyboardShowKeyboardShortcuts']);
74 }; 74 };
75 }, 75 },
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 var instance = KeyboardOverlay.getInstance(); 170 var instance = KeyboardOverlay.getInstance();
171 return instance[name + '_'].apply(instance, arguments); 171 return instance[name + '_'].apply(instance, arguments);
172 }; 172 };
173 }); 173 });
174 174
175 // Export 175 // Export
176 return { 176 return {
177 KeyboardOverlay: KeyboardOverlay 177 KeyboardOverlay: KeyboardOverlay
178 }; 178 };
179 }); 179 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698