Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Side by Side Diff: chromeos/login_event_recorder.h

Issue 409113002: Refactoring: get rid of notificataions in ParallelAuthenticator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_LOGIN_EVENT_RECORDER_H_ 5 #ifndef CHROMEOS_LOGIN_EVENT_RECORDER_H_
6 #define CHROMEOS_LOGIN_EVENT_RECORDER_H_ 6 #define CHROMEOS_LOGIN_EVENT_RECORDER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "chromeos/chromeos_export.h" 11 #include "chromeos/chromeos_export.h"
12 12
13 namespace chromeos { 13 namespace chromeos {
14 14
15 // LoginEventRecorder records the bootimes of Chrome OS. 15 // LoginEventRecorder records the bootimes of Chrome OS.
16 // Actual implementation is handled by delegate. 16 // Actual implementation is handled by delegate.
17 class CHROMEOS_EXPORT LoginEventRecorder { 17 class CHROMEOS_EXPORT LoginEventRecorder {
18 public: 18 public:
19 class Delegate { 19 class Delegate {
20 public: 20 public:
21 virtual void AddLoginTimeMarker(const std::string& marker_name, 21 virtual void AddLoginTimeMarker(const std::string& marker_name,
22 bool send_to_uma) = 0; 22 bool send_to_uma) = 0;
23 virtual void RecordAuthenticationSuccess() = 0;
24 virtual void RecordAuthenticationFailure() = 0;
23 }; 25 };
24 LoginEventRecorder(); 26 LoginEventRecorder();
25 virtual ~LoginEventRecorder(); 27 virtual ~LoginEventRecorder();
26 28
27 static LoginEventRecorder* Get(); 29 static LoginEventRecorder* Get();
28 30
29 void SetDelegate(Delegate* delegate); 31 void SetDelegate(Delegate* delegate);
30 32
31 // Add a time marker for login. A timeline will be dumped to 33 // Add a time marker for login. A timeline will be dumped to
32 // /tmp/login-times-sent after login is done. If |send_to_uma| is true 34 // /tmp/login-times-sent after login is done. If |send_to_uma| is true
33 // the time between this marker and the last will be sent to UMA with 35 // the time between this marker and the last will be sent to UMA with
34 // the identifier BootTime.|marker_name|. 36 // the identifier BootTime.|marker_name|.
35 void AddLoginTimeMarker(const std::string& marker_name, bool send_to_uma); 37 void AddLoginTimeMarker(const std::string& marker_name, bool send_to_uma);
36 38
39 void RecordAuthenticationSuccess();
Nikita (slow) 2014/07/22 15:50:26 nit: Add short comment (single one for both method
Denis Kuznetsov (DE-MUC) 2014/08/20 13:50:19 Done.
40 void RecordAuthenticationFailure();
41
37 private: 42 private:
38 Delegate* delegate_; 43 Delegate* delegate_;
39 44
40 DISALLOW_COPY_AND_ASSIGN(LoginEventRecorder); 45 DISALLOW_COPY_AND_ASSIGN(LoginEventRecorder);
41 }; 46 };
42 47
43 } // namespace chromeos 48 } // namespace chromeos
44 49
45 #endif // CHROMEOS_LOGIN_EVENT_RECORDER_H_ 50 #endif // CHROMEOS_LOGIN_EVENT_RECORDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698