Refactoring: get rid of notificataions in ParallelAuthenticator

chrome/browser/chromeos/boot_times_loader.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_BOOT_TIMES_LOADER_H_
 #define CHROME_BROWSER_CHROMEOS_BOOT_TIMES_LOADER_H_
 
 #include <set>
 #include <string>
 
@@ skipping 24 matching lines @@
 class BootTimesLoader : public content::NotificationObserver,
                         public LoginEventRecorder::Delegate {
  public:
   BootTimesLoader();
   virtual ~BootTimesLoader();
 
   static BootTimesLoader* Get();
 
   // LoginEventRecorder::Delegate override.
 
   // Add a time marker for login. A timeline will be dumped to

[Nikita (slow), 2014/07/22 15:50:26]

nit: move this comment to login_event_recorder.h
nit: drop all empty lines:

// LoginEventRecorder::Delegate override.
virtual ...
virtual ...

[Denis Kuznetsov (DE-MUC), 2014/08/20 13:50:19]

Done.

   // /tmp/login-times-sent after login is done. If |send_to_uma| is true
   // the time between this marker and the last will be sent to UMA with
   // the identifier BootTime.|marker_name|.
   virtual void AddLoginTimeMarker(const std::string& marker_name,
                                   bool send_to_uma) OVERRIDE;
 
+  virtual void RecordAuthenticationSuccess() OVERRIDE;

[stevenjb, 2014/07/22 16:11:04]

nit: WS

[Denis Kuznetsov (DE-MUC), 2014/08/20 13:50:19]

Done.

+  virtual void RecordAuthenticationFailure() OVERRIDE;
+
   // Add a time marker for logout. A timeline will be dumped to
   // /tmp/logout-times-sent after logout is done. If |send_to_uma| is true
   // the time between this marker and the last will be sent to UMA with
   // the identifier ShutdownTime.|marker_name|.
   void AddLogoutTimeMarker(const std::string& marker_name, bool send_to_uma);
 
   // Records current uptime and disk usage for metrics use.
   // Posts task to file thread.
   // name will be used as part of file names in /tmp.
   // Existing stats files will not be overwritten.
@@ skipping 126 matching lines @@
   bool login_done_;
 
   bool restart_requested_;
 
   DISALLOW_COPY_AND_ASSIGN(BootTimesLoader);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_BOOT_TIMES_LOADER_H_