Move mojo java bindings to mojo/public

Move mojo java bindings to mojo/public

R=cmasone@chromium.org,viettrungluu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284701

[Chris Masone, 2014-07-21 16:56:05]

https://codereview.chromium.org/407733006/diff/20001/mojo/public/BUILD.gn
File mojo/public/BUILD.gn (right):

https://codereview.chromium.org/407733006/diff/20001/mojo/public/BUILD.gn#new...
mojo/public/BUILD.gn:19: "//mojo/public/java_system",
The way you've got it now, these should be written like
mojo/public/java:java_system

Apparently, the GN style guide recommends using simple nouns, even if they're
redundant, relying on the path to disambiguate. So you should probably re-name
the targets in mojo/public/java/BUILD.gn to "system" and "bindings" and then you
can just do "//mojo/public/java:system"

https://codereview.chromium.org/407733006/diff/20001/mojo/public/java/BUILD.gn
File mojo/public/java/BUILD.gn (right):

https://codereview.chromium.org/407733006/diff/20001/mojo/public/java/BUILD.g...
mojo/public/java/BUILD.gn:24: android_library("java_bindings") {
I believe this actually depends on more stuff, if I remember correctly. When I
was doing this last week, it wasn't simply that this lived outside of public/,
but also that it depended on more java code that no one had yet written GN
targets for.

[qsr, 2014-07-21 18:21:03]

On Jul 21, 2014 6:56 PM, <cmasone@chromium.org> wrote:
>
>
>https://codereview.chromium.org/407733006/diff/20001/mojo/public/BUILD.gn
> File mojo/public/BUILD.gn (right):
>
>
https://codereview.chromium.org/407733006/diff/20001/mojo/public/BUILD.gn#new...
> mojo/public/BUILD.gn:19: "//mojo/public/java_system",
> The way you've got it now, these should be written like
> mojo/public/java:java_system
>
> Apparently, the GN style guide recommends using simple nouns, even if
> they're redundant, relying on the path to disambiguate. So you should
> probably re-name the targets in mojo/public/java/BUILD.gn to "system"
> and "bindings" and then you can just do "//mojo/public/java:system"
>
>
https://codereview.chromium.org/407733006/diff/20001/mojo/public/java/BUILD.gn
> File mojo/public/java/BUILD.gn (right):
>
>
https://codereview.chromium.org/407733006/diff/20001/mojo/public/java/BUILD.g...
> mojo/public/java/BUILD.gn:24: android_library("java_bindings") {
> I believe this actually depends on more stuff, if I remember correctly.
> When I was doing this last week, it wasn't simply that this lived
> outside of public/, but also that it depended on more java code that no
> one had yet written GN targets for.

Are you thinking about the jsr target? It  has been removed. If you look at
the gyp file, this only depends on Java—public. Any other dependency would
be a bug, as this must be part of the SDK.

>https <https://codereview.chromium.org/407733006/>://
<https://codereview.chromium.org/407733006/>codereview.chromium.org
<https://codereview.chromium.org/407733006/>/407733006/
<https://codereview.chromium.org/407733006/>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Chris Masone, 2014-07-21 18:24:44]

I don't _think_ it was the jsr target. I may be misremembering :-)

As long as the GN build works and only depends on
//mojo/public/java:system, then it's all good


On Mon, Jul 21, 2014 at 11:21 AM, Benjamin Lerman <qsr@chromium.org> wrote:

>
> On Jul 21, 2014 6:56 PM, <cmasone@chromium.org> wrote:
> >
> >
> >https://codereview.chromium.org/407733006/diff/20001/mojo/public/BUILD.gn
> > File mojo/public/BUILD.gn (right):
> >
> >
>
https://codereview.chromium.org/407733006/diff/20001/mojo/public/BUILD.gn#new...
> > mojo/public/BUILD.gn:19: "//mojo/public/java_system",
> > The way you've got it now, these should be written like
> > mojo/public/java:java_system
> >
> > Apparently, the GN style guide recommends using simple nouns, even if
> > they're redundant, relying on the path to disambiguate. So you should
> > probably re-name the targets in mojo/public/java/BUILD.gn to "system"
> > and "bindings" and then you can just do "//mojo/public/java:system"
> >
> >
>
https://codereview.chromium.org/407733006/diff/20001/mojo/public/java/BUILD.gn
> > File mojo/public/java/BUILD.gn (right):
> >
> >
>
https://codereview.chromium.org/407733006/diff/20001/mojo/public/java/BUILD.g...
> > mojo/public/java/BUILD.gn:24: android_library("java_bindings") {
> > I believe this actually depends on more stuff, if I remember correctly.
> > When I was doing this last week, it wasn't simply that this lived
> > outside of public/, but also that it depended on more java code that no
> > one had yet written GN targets for.
>
> Are you thinking about the jsr target? It  has been removed. If you look
> at the gyp file, this only depends on Java—public. Any other dependency
> would be a bug, as this must be part of the SDK.
>
> >https <https://codereview.chromium.org/407733006/>://
> <https://codereview.chromium.org/407733006/>codereview.chromium.org
> <https://codereview.chromium.org/407733006/>/407733006/
> <https://codereview.chromium.org/407733006/>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[qsr, 2014-07-22 08:17:59]

https://chromiumcodereview.appspot.com/407733006/diff/20001/mojo/public/BUILD.gn
File mojo/public/BUILD.gn (right):

https://chromiumcodereview.appspot.com/407733006/diff/20001/mojo/public/BUILD...
mojo/public/BUILD.gn:19: "//mojo/public/java_system",
On 2014/07/21 16:56:05, Chris Masone wrote:
> The way you've got it now, these should be written like
> mojo/public/java:java_system
> 
> Apparently, the GN style guide recommends using simple nouns, even if they're
> redundant, relying on the path to disambiguate. So you should probably re-name
> the targets in mojo/public/java/BUILD.gn to "system" and "bindings" and then
you
> can just do "//mojo/public/java:system"

Done.

[qsr, 2014-07-22 08:32:56]

On 2014/07/21 18:24:44, Chris Masone wrote:
> I don't _think_ it was the jsr target. I may be misremembering :-)
> 
> As long as the GN build works and only depends on
> //mojo/public/java:system, then it's all good

http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...

Seems to work.

> 
> On Mon, Jul 21, 2014 at 11:21 AM, Benjamin Lerman <mailto:qsr@chromium.org>
wrote:
> 
> >
> > On Jul 21, 2014 6:56 PM, <mailto:cmasone@chromium.org> wrote:
> > >
> > >
> > >https://codereview.chromium.org/407733006/diff/20001/mojo/public/BUILD.gn
> > > File mojo/public/BUILD.gn (right):
> > >
> > >
> >
>
https://codereview.chromium.org/407733006/diff/20001/mojo/public/BUILD.gn#new...
> > > mojo/public/BUILD.gn:19: "//mojo/public/java_system",
> > > The way you've got it now, these should be written like
> > > mojo/public/java:java_system
> > >
> > > Apparently, the GN style guide recommends using simple nouns, even if
> > > they're redundant, relying on the path to disambiguate. So you should
> > > probably re-name the targets in mojo/public/java/BUILD.gn to "system"
> > > and "bindings" and then you can just do "//mojo/public/java:system"
> > >
> > >
> >
> https://codereview.chromium.org/407733006/diff/20001/mojo/public/java/BUILD.gn
> > > File mojo/public/java/BUILD.gn (right):
> > >
> > >
> >
>
https://codereview.chromium.org/407733006/diff/20001/mojo/public/java/BUILD.g...
> > > mojo/public/java/BUILD.gn:24: android_library("java_bindings") {
> > > I believe this actually depends on more stuff, if I remember correctly.
> > > When I was doing this last week, it wasn't simply that this lived
> > > outside of public/, but also that it depended on more java code that no
> > > one had yet written GN targets for.
> >
> > Are you thinking about the jsr target? It  has been removed. If you look
> > at the gyp file, this only depends on Java—public. Any other dependency
> > would be a bug, as this must be part of the SDK.
> >
> > >https <https://codereview.chromium.org/407733006/%3E://
> > <https://codereview.chromium.org/407733006/%3Ecodereview.chromium.org
> > <https://codereview.chromium.org/407733006/%3E/407733006/
> > <https://codereview.chromium.org/407733006/>
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Chris Masone, 2014-07-22 12:48:39]

Lgtm
On Jul 22, 2014 1:32 AM, <qsr@chromium.org> wrote:

> On 2014/07/21 18:24:44, Chris Masone wrote:
>
>> I don't _think_ it was the jsr target. I may be misremembering :-)
>>
>
>  As long as the GN build works and only depends on
>> //mojo/public/java:system, then it's all good
>>
>
> http://build.chromium.org/p/tryserver.chromium/builders/
> android_chromium_gn_compile_rel/builds/24533/
>
> Seems to work.
>
>
>  On Mon, Jul 21, 2014 at 11:21 AM, Benjamin Lerman <mailto:
>> qsr@chromium.org>
>>
> wrote:
>
>  >
>> > On Jul 21, 2014 6:56 PM, <mailto:cmasone@chromium.org> wrote:
>> > >
>> > >
>> > >https://codereview.chromium.org/407733006/diff/20001/mojo/
>> public/BUILD.gn
>> > > File mojo/public/BUILD.gn (right):
>> > >
>> > >
>> >
>>
>
> https://codereview.chromium.org/407733006/diff/20001/mojo/
> public/BUILD.gn#newcode19
>
>> > > mojo/public/BUILD.gn:19: "//mojo/public/java_system",
>> > > The way you've got it now, these should be written like
>> > > mojo/public/java:java_system
>> > >
>> > > Apparently, the GN style guide recommends using simple nouns, even if
>> > > they're redundant, relying on the path to disambiguate. So you should
>> > > probably re-name the targets in mojo/public/java/BUILD.gn to "system"
>> > > and "bindings" and then you can just do "//mojo/public/java:system"
>> > >
>> > >
>> >
>> https://codereview.chromium.org/407733006/diff/20001/mojo/
>> public/java/BUILD.gn
>> > > File mojo/public/java/BUILD.gn (right):
>> > >
>> > >
>> >
>>
>
> https://codereview.chromium.org/407733006/diff/20001/mojo/
> public/java/BUILD.gn#newcode24
>
>> > > mojo/public/java/BUILD.gn:24: android_library("java_bindings") {
>> > > I believe this actually depends on more stuff, if I remember
>> correctly.
>> > > When I was doing this last week, it wasn't simply that this lived
>> > > outside of public/, but also that it depended on more java code that
>> no
>> > > one had yet written GN targets for.
>> >
>> > Are you thinking about the jsr target? It  has been removed. If you look
>> > at the gyp file, this only depends on Java--public. Any other dependency
>> > would be a bug, as this must be part of the SDK.
>> >
>> > >https <https://codereview.chromium.org/407733006/%3E://
>> > <https://codereview.chromium.org/407733006/%3Ecodereview.chromium.org
>> > <https://codereview.chromium.org/407733006/%3E/407733006/
>> > <https://codereview.chromium.org/407733006/>
>> >
>>
>
>  To unsubscribe from this group and stop receiving emails from it, send an
>>
> email
>
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>
>
> https://codereview.chromium.org/407733006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[qsr, 2014-07-22 12:49:10]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-07-22 12:50:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/407733006/40001

[commit-bot: I haz the power, 2014-07-22 12:50:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 12:50:05]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[qsr, 2014-07-22 12:55:58]

Hum, Chris, any reason not to have given a full LGTM?

[Chris Masone, 2014-07-22 13:01:21]

Maybe because it was via email?

I'll get on my laptop in a few
On Jul 22, 2014 5:55 AM, <qsr@chromium.org> wrote:

>  Hum, Chris, any reason not to have given a full LGTM?
>
> https://codereview.chromium.org/407733006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Chris Masone, 2014-07-22 13:15:10]

LGTM

[qsr, 2014-07-22 13:18:02]

The CQ bit was checked by qsr@chromium.org

[qsr, 2014-07-22 13:18:46]

On 2014/07/22 13:01:21, Chris Masone wrote:
> Maybe because it was via email?

 I think the issue was that the message was Lgtm instead of using full caps.

> 
> I'll get on my laptop in a few
> On Jul 22, 2014 5:55 AM, <mailto:qsr@chromium.org> wrote:
> 
> >  Hum, Chris, any reason not to have given a full LGTM?
> >
> > https://codereview.chromium.org/407733006/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-07-22 13:18:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/407733006/40001

[commit-bot: I haz the power, 2014-07-22 16:29:42]

Change committed as 284701