Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 407083002: [Autofill] Include fields with autocomplete="off" in server upload requests. (Closed)

Created:
6 years, 5 months ago by Ilya Sherman
Modified:
6 years, 5 months ago
Reviewers:
vadimb1, Evan Stade
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Autofill] Include fields with autocomplete="off" in server upload requests. BUG=177419 TEST=browser_tests R=estade@chromium.org, vadimb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285176

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Update test expectations #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -13 lines) Patch
A chrome/browser/autofill/autofill_server_browsertest.cc View 1 chunk +174 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/autofill/form_autocomplete_browsertest.cc View 1 2 5 chunks +41 lines, -12 lines 1 comment Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Ilya Sherman
6 years, 5 months ago (2014-07-22 06:05:16 UTC) #1
vadimb1
lgtm LGTM but I have little knowledge of the client side code so don't rely ...
6 years, 5 months ago (2014-07-22 19:56:02 UTC) #2
Ilya Sherman
On 2014/07/22 19:56:02, vadimb1 wrote: > LGTM but I have little knowledge of the client ...
6 years, 5 months ago (2014-07-22 20:19:20 UTC) #3
Evan Stade
lgtm
6 years, 5 months ago (2014-07-23 00:09:13 UTC) #4
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-23 17:30:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/407083002/1
6 years, 5 months ago (2014-07-23 17:31:20 UTC) #6
Ilya Sherman
Evan, please take another quick look -- I ended up needing to update some test ...
6 years, 5 months ago (2014-07-23 23:07:04 UTC) #7
Evan Stade
lgtm https://chromiumcodereview.appspot.com/407083002/diff/40001/chrome/renderer/autofill/form_autocomplete_browsertest.cc File chrome/renderer/autofill/form_autocomplete_browsertest.cc (right): https://chromiumcodereview.appspot.com/407083002/diff/40001/chrome/renderer/autofill/form_autocomplete_browsertest.cc#newcode116 chrome/renderer/autofill/form_autocomplete_browsertest.cc:116: TEST_F(FormAutocompleteTest, DynamicAutoCompleteOffFormSubmit) { I question whether this test ...
6 years, 5 months ago (2014-07-23 23:14:50 UTC) #8
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-23 23:35:20 UTC) #9
Ilya Sherman
The CQ bit was unchecked by isherman@chromium.org
6 years, 5 months ago (2014-07-23 23:35:33 UTC) #10
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-23 23:35:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/407083002/40001
6 years, 5 months ago (2014-07-23 23:36:55 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 05:41:18 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 10:49:11 UTC) #14
Message was sent while issue was closed. 
Change committed as 285176

Powered by Google App Engine
This is Rietveld 408576698