Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: ui/webui/resources/js/event_tracker.js

Issue 405743002: Typecheck some of ui/webui/resources/js/ with Closure compiler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cr.isMac fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/webui/resources/js/cr.js ('k') | ui/webui/resources/js/i18n_template.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/js/event_tracker.js
diff --git a/ui/webui/resources/js/event_tracker.js b/ui/webui/resources/js/event_tracker.js
index 12d593081e34f86358f5f096b61eb9d165e0c367..be00b0d8dcfbe5c518535cfd802240a788e13a3c 100644
--- a/ui/webui/resources/js/event_tracker.js
+++ b/ui/webui/resources/js/event_tracker.js
@@ -2,43 +2,46 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-/** @fileoverview EventTracker is a simple class that manages the addition and
- * removal of DOM event listeners. In particular, it keeps track of all
- * listeners that have been added and makes it easy to remove some or all of
- * them without requiring all the information again. This is particularly
- * handy when the listener is a generated function such as a lambda or the
- * result of calling Function.bind.
+/**
+ * @fileoverview EventTracker is a simple class that manages the addition and
+ * removal of DOM event listeners. In particular, it keeps track of all
+ * listeners that have been added and makes it easy to remove some or all of
+ * them without requiring all the information again. This is particularly handy
+ * when the listener is a generated function such as a lambda or the result of
+ * calling Function.bind.
*/
+/**
+ * The type of the internal tracking entry. TODO(dbeam): move this back to
+ * EventTracker.Entry when https://github.com/google/closure-compiler/issues/544
+ * is fixed.
+ * @typedef {{node: !Node,
+ * eventType: string,
+ * listener: Function,
+ * capture: boolean}}
+ */
+var EventTrackerEntry;
+
// Use an anonymous function to enable strict mode just for this file (which
-// will be concatenated with other files when embedded in Chrome)
+// will be concatenated with other files when embedded in Chrome).
var EventTracker = (function() {
'use strict';
/**
- * Create an EventTracker to track a set of events.
- * EventTracker instances are typically tied 1:1 with other objects or
- * DOM elements whose listeners should be removed when the object is disposed
- * or the corresponding elements are removed from the DOM.
- * @constructor
+ * Create an EventTracker to track a set of events.
+ * EventTracker instances are typically tied 1:1 with other objects or
+ * DOM elements whose listeners should be removed when the object is disposed
+ * or the corresponding elements are removed from the DOM.
+ * @constructor
*/
function EventTracker() {
/**
- * @type {Array.<EventTracker.Entry>}
- * @private
+ * @type {Array.<EventTrackerEntry>}
+ * @private
*/
this.listeners_ = [];
}
- /**
- * The type of the internal tracking entry.
- * @typedef {{node: !Node,
- * eventType: string,
- * listener: Function,
- * capture: boolean}}
- */
- EventTracker.Entry;
-
EventTracker.prototype = {
/**
* Add an event listener - replacement for Node.addEventListener.
@@ -83,9 +86,9 @@ var EventTracker = (function() {
};
/**
- * Remove a single event listener given it's tracker entry. It's up to the
+ * Remove a single event listener given it's tracking entry. It's up to the
* caller to ensure the entry is removed from listeners_.
- * @param {EventTracker.Entry} h The entry describing the listener to remove.
+ * @param {EventTrackerEntry} h The entry describing the listener to remove.
* @private
*/
EventTracker.removeEventListener_ = function(h) {
« no previous file with comments | « ui/webui/resources/js/cr.js ('k') | ui/webui/resources/js/i18n_template.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698