Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Unified Diff: Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address aandrey's comments #2 Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/Source/devtools/front_end/console/ConsoleViewMessage.js b/Source/devtools/front_end/console/ConsoleViewMessage.js
index 0eb785e25b215ae914393642f5c637019a4be1f7..829c4ee8106658402176d9d6aaedede2e726fdb1 100644
--- a/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -266,7 +266,7 @@ WebInspector.ConsoleViewMessage.prototype = {
return this._linkifier.linkifyCSSLocation(cssLocation, "console-message-url");
}
- return this._linkifier.linkifyLocation(target, url, lineNumber, columnNumber, "console-message-url");
+ return this._linkifier.linkifyScriptLocation(target, null, url, lineNumber, columnNumber, "console-message-url");
},
/**
@@ -277,10 +277,10 @@ WebInspector.ConsoleViewMessage.prototype = {
{
console.assert(this._linkifier);
var target = this._target();
- if (!this._linkifier || !target)
+ if (!this._linkifier)
return null;
- var rawLocation = this._target().debuggerModel.createRawLocationByConsoleCallFrame(callFrame);
- return this._linkifier.linkifyRawLocation(rawLocation, "console-message-url");
+
+ return this._linkifier.linkifyConsoleCallFrame(target, callFrame, "console-message-url");
},
/**

Powered by Google App Engine
This is Rietveld 408576698