LayoutTests/inspector/jump-to-previous-editing-location.html - Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/jump-to-previous-editing-location.html

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address aandrey's comments #2 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/extensions/extensions-console-expected.txt ('k') | Source/devtools/front_end/components/ObjectPopoverHelper.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/jump-to-previous-editing-location.html

diff --git a/LayoutTests/inspector/jump-to-previous-editing-location.html b/LayoutTests/inspector/jump-to-previous-editing-location.html

index b27e0e3f06506a3bbf93d6d2859a7bb0af66d52b..4caa5fd0f8af244e73b81f21e2caeaa9e7b2e4a6 100644

--- a/LayoutTests/inspector/jump-to-previous-editing-location.html

+++ b/LayoutTests/inspector/jump-to-previous-editing-location.html

@@ -223,7 +223,7 @@ function test()

var linkifier = new WebInspector.Linkifier();

WebInspector.inspectorView.showPanel("timeline");

var anchorURI = uiSourceCode.url;

- var anchor = linkifier.linkifyLocation(WebInspector.targetManager.mainTarget(), anchorURI, 10, 1);

+ var anchor = linkifier.linkifyScriptLocation(WebInspector.targetManager.mainTarget(), null, anchorURI, 10, 1);

WebInspector.Revealer.reveal(anchor.__uiLocation);

InspectorTest.addResult("Selection: " + panel.visibleView.textEditor.selection().toString());

dumpSelection(panel.visibleView.textEditor, "Showed anchor in " + anchorURI.split("/").pop() + " with line 333 column 3");