Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address aandrey's comments #2 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 2151 matching lines...) Expand 10 before | Expand all | Expand 10 after
2162 return; 2162 return;
2163 } 2163 }
2164 2164
2165 var stackDiv = this.element.createChild("div", "heap-allocation-stack"); 2165 var stackDiv = this.element.createChild("div", "heap-allocation-stack");
2166 for (var i = 0; i < frames.length; i++) { 2166 for (var i = 0; i < frames.length; i++) {
2167 var frame = frames[i]; 2167 var frame = frames[i];
2168 var frameDiv = stackDiv.createChild("div", "stack-frame"); 2168 var frameDiv = stackDiv.createChild("div", "stack-frame");
2169 var name = frameDiv.createChild("div"); 2169 var name = frameDiv.createChild("div");
2170 name.textContent = frame.functionName; 2170 name.textContent = frame.functionName;
2171 if (frame.scriptId) { 2171 if (frame.scriptId) {
2172 var urlElement = this._linkifier.linkifyLocationByScriptId(this. _weakTarget.get(), String(frame.scriptId), frame.scriptName, frame.line - 1, fra me.column - 1); 2172 var urlElement = this._linkifier.linkifyScriptLocation(this._wea kTarget.get(), String(frame.scriptId), frame.scriptName, frame.line - 1, frame.c olumn - 1);
2173 frameDiv.appendChild(urlElement); 2173 frameDiv.appendChild(urlElement);
2174 } 2174 }
2175 } 2175 }
2176 }, 2176 },
2177 2177
2178 __proto__: WebInspector.View.prototype 2178 __proto__: WebInspector.View.prototype
2179 } 2179 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js ('k') | Source/devtools/front_end/sdk/DOMModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698