Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2275)

Unified Diff: Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 404763002: DevTools: Inject styleSheetId in WebInspector.CSSLocation constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/Source/devtools/front_end/console/ConsoleViewMessage.js b/Source/devtools/front_end/console/ConsoleViewMessage.js
index d0946b91a6d77f4f6c1de7045fd3baf01ec07a97..c206a2ff51acf4a2e87ad7e8624fb19e1a1c59bc 100644
--- a/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -262,8 +262,9 @@ WebInspector.ConsoleViewMessage.prototype = {
columnNumber = columnNumber ? columnNumber - 1 : 0;
if (this._message.source === WebInspector.ConsoleMessage.MessageSource.CSS) {
var headerIds = target.cssModel.styleSheetIdsForURL(url);
- var cssLocation = new WebInspector.CSSLocation(target, url, lineNumber, columnNumber);
- return this._linkifier.linkifyCSSLocation(headerIds[0] || null, cssLocation, "console-message-url");
+ console.assert(headerIds[0]);
vsevik 2014/07/18 15:45:37 Please revert this
+ var cssLocation = new WebInspector.CSSLocation(target, headerIds[0], url, lineNumber, columnNumber);
+ return this._linkifier.linkifyCSSLocation(cssLocation, "console-message-url");
}
return this._linkifier.linkifyLocation(target, url, lineNumber, columnNumber, "console-message-url");

Powered by Google App Engine
This is Rietveld 408576698