DevTools: Inject styleSheetId in WebInspector.CSSLocation constructor

DevTools: Inject styleSheetId in WebInspector.CSSLocation constructor

Style sheet ID is required for the live location construction, and it is
always known at the point where CSSLocation instances are constructed.

R=vsevik

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178550

[vsevik, 2014-07-18 13:44:54]

https://chromiumcodereview.appspot.com/404763002/diff/1/Source/devtools/front...
File Source/devtools/front_end/sdk/CSSStyleModel.js (right):

https://chromiumcodereview.appspot.com/404763002/diff/1/Source/devtools/front...
Source/devtools/front_end/sdk/CSSStyleModel.js:740: WebInspector.CSSLocation =
function(target, styleSheetId, url, lineNumber, columnNumber)
Let's make CSSLocation that always has a style sheet id and move media specific
cases where we need URL to callers/media impl.

[vsevik, 2014-07-18 14:02:57]

On 2014/07/18 13:44:54, vsevik wrote:
>
https://chromiumcodereview.appspot.com/404763002/diff/1/Source/devtools/front...
> File Source/devtools/front_end/sdk/CSSStyleModel.js (right):
> 
>
https://chromiumcodereview.appspot.com/404763002/diff/1/Source/devtools/front...
> Source/devtools/front_end/sdk/CSSStyleModel.js:740: WebInspector.CSSLocation =
> function(target, styleSheetId, url, lineNumber, columnNumber)
> Let's make CSSLocation that always has a style sheet id and move media
specific
> cases where we need URL to callers/media impl.

Looks like this is not going to work since stylesheet could be removed later.

lgtm.

[vsevik, 2014-07-18 15:45:37]

lgtm

https://chromiumcodereview.appspot.com/404763002/diff/20001/Source/devtools/f...
File Source/devtools/front_end/console/ConsoleViewMessage.js (right):

https://chromiumcodereview.appspot.com/404763002/diff/20001/Source/devtools/f...
Source/devtools/front_end/console/ConsoleViewMessage.js:265:
console.assert(headerIds[0]);
Please revert this

[apavlov, 2014-07-18 15:51:13]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-07-18 15:51:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/apavlov@chromium.org/404763002/40001

[commit-bot: I haz the power, 2014-07-18 15:52:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 15:52:10]

Failed to apply patch for
LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html
  Hunk #1 FAILED at 69.
  1 out of 2 hunks FAILED -- saving rejects to file
LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html.rej

Patch:      
LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html
Index:
LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html
diff --git
a/LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html
b/LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html
index
af30034bf3d2e2718bcb1b6b8adf694103b1bc1d..50150b7159857a7bc9010ef89e593ca589037272
100644
---
a/LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html
+++
b/LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html
@@ -69,7 +69,7 @@ function test()
     var namePrefix = "update-locations-on-filesystem-scss-load."
     var cssURL = resourcesURL + namePrefix + "css";
     var scssURL = resourcesURL + namePrefix + "scss";
-    var cssLocation = new
WebInspector.CSSLocation(WebInspector.targetManager.activeTarget(), cssURL, 0,
1);
+    var cssLocation = new
WebInspector.CSSLocation(WebInspector.targetManager.activeTarget(), 1, cssURL,
0, 1);
     var scssContent =
         ["a {",
         "  foo: bar;",
@@ -97,7 +97,7 @@ function test()
     addMockHeader(cssURL, cssURL + ".map");
     InspectorTest.addResult("Adding network resource.");
     InspectorTest.addMockUISourceCodeToWorkspace(cssURL,
WebInspector.resourceTypes.Stylesheet, cssContent);
-    liveLocation = cssLocation.createLiveLocation("1", updateDelegate);
+    liveLocation = cssLocation.createLiveLocation(updateDelegate);
     dumpLiveLocation();
 
     InspectorTest.addResult("Adding filesystem SCSS.");

[apavlov, 2014-07-21 10:23:44]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-07-21 10:23:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/apavlov@chromium.org/404763002/60001

[apavlov, 2014-07-21 10:34:51]

The CQ bit was unchecked by apavlov@chromium.org

[apavlov, 2014-07-21 10:34:54]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-07-21 10:34:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/apavlov@chromium.org/404763002/60001

[commit-bot: I haz the power, 2014-07-21 11:23:41]

Change committed as 178550