DevTools: [CodeMirror] remove auto-inserted whitespaces

DevTools: [CodeMirror] remove auto-inserted whitespaces

Currently, text editor auto-inserts spaces/tabs in certain cases. For example,
if you hit "enter" when your cursor is located on indented line, the new line
will be auto-indented. If you hit "enter" one more time, a new line will be
added, but the previous empty line with trailing auto-added whitespaces will
persist.

This patch suggests removing auto-added indents on every next "enter" keypress.
Note, that they will be removed only if they have not been edited.

R=vsevik, apavlov

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178515

[vsevik, 2014-07-18 13:55:42]

lgtm

https://chromiumcodereview.appspot.com/402433007/diff/20001/Source/devtools/f...
File Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js (right):

https://chromiumcodereview.appspot.com/402433007/diff/20001/Source/devtools/f...
Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:329:
_onAutoAppendedSpaces: function()
Let's split this into two methods - one for adding auto appended spaces and
another one for removing them.
I think the latter one should be called on every editing action

[lushnikov, 2014-07-18 16:34:40]

https://chromiumcodereview.appspot.com/402433007/diff/20001/Source/devtools/f...
File Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js (right):

https://chromiumcodereview.appspot.com/402433007/diff/20001/Source/devtools/f...
Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:329:
_onAutoAppendedSpaces: function()
On 2014/07/18 13:55:42, vsevik wrote:
> Let's split this into two methods - one for adding auto appended spaces and
> another one for removing them.
> I think the latter one should be called on every editing action

It didn't work out that easy =/

[lushnikov, 2014-07-18 16:34:43]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2014-07-18 16:35:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lushnikov@chromium.org/402433007/20001

[commit-bot: I haz the power, 2014-07-18 17:38:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/16160)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17770)

[commit-bot: I haz the power, 2014-07-18 18:06:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 18:06:20]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[lushnikov, 2014-07-19 10:22:48]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2014-07-19 10:23:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lushnikov@chromium.org/402433007/20001

[commit-bot: I haz the power, 2014-07-19 11:25:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/16251)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17870)

[commit-bot: I haz the power, 2014-07-19 11:46:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-19 11:46:56]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[lushnikov, 2014-07-19 12:05:44]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2014-07-19 12:05:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lushnikov@chromium.org/402433007/40001

[commit-bot: I haz the power, 2014-07-19 13:04:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17874)

[commit-bot: I haz the power, 2014-07-19 13:36:25]

Change committed as 178515