Refactoring : Move OnlineAttempt to chromeos/login

Refactoring : Move OnlineAttempt to chromeos/login
Also moved tpm_password_fetcher to chromeos/ and got rid of
obsolette login/auth/mount_manager

BUG=387613
R=nkostylev@chromium.org
TBR=stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290562

[Denis Kuznetsov (DE-MUC), 2014-07-22 13:48:58]

Nikita as main reviewer,
Steven as owner of DEPS and general chromeos/.

[Nikita (slow), 2014-07-22 14:19:27]

https://chromiumcodereview.appspot.com/402403004/diff/1/chromeos/login/DEPS
File chromeos/login/DEPS (right):

https://chromiumcodereview.appspot.com/402403004/diff/1/chromeos/login/DEPS#n...
chromeos/login/DEPS:2: "+chrome/test/base",
You should use TestBrowsingContext and drop dependency on TestProfile.

[Nikita (slow), 2014-07-22 14:23:57]

https://chromiumcodereview.appspot.com/402403004/diff/1/chromeos/login/auth/m...
File chromeos/login/auth/mock_url_fetchers.h (right):

https://chromiumcodereview.appspot.com/402403004/diff/1/chromeos/login/auth/m...
chromeos/login/auth/mock_url_fetchers.h:26: class CHROMEOS_EXPORT
ExpectCanceledFetcher : public net::TestURLFetcher {
You should drop CHROMEOS_EXPORT for these classes since they are only used in
one test.

[Denis Kuznetsov (DE-MUC), 2014-07-22 15:41:32]

https://chromiumcodereview.appspot.com/402403004/diff/1/chromeos/login/DEPS
File chromeos/login/DEPS (right):

https://chromiumcodereview.appspot.com/402403004/diff/1/chromeos/login/DEPS#n...
chromeos/login/DEPS:2: "+chrome/test/base",
On 2014/07/22 14:19:27, Nikita Kostylev wrote:
> You should use TestBrowsingContext and drop dependency on TestProfile.

Done.

https://chromiumcodereview.appspot.com/402403004/diff/1/chromeos/login/auth/m...
File chromeos/login/auth/mock_url_fetchers.h (right):

https://chromiumcodereview.appspot.com/402403004/diff/1/chromeos/login/auth/m...
chromeos/login/auth/mock_url_fetchers.h:26: class CHROMEOS_EXPORT
ExpectCanceledFetcher : public net::TestURLFetcher {
On 2014/07/22 14:23:56, Nikita Kostylev wrote:
> You should drop CHROMEOS_EXPORT for these classes since they are only used in
> one test.

Done.

[Nikita (slow), 2014-07-22 15:44:32]

lgtm

[stevenjb, 2014-07-22 16:35:37]

https://chromiumcodereview.appspot.com/402403004/diff/40001/chromeos/login/au...
File chromeos/login/auth/online_attempt.cc (right):

https://chromiumcodereview.appspot.com/402403004/diff/40001/chromeos/login/au...
chromeos/login/auth/online_attempt.cc:19: #include
"content/public/browser/browser_thread.h"
Unfortunately this is a layering violation. src/chromeos is for low-level OS
code, not content or UI code. (I probably should have named it
src/system/chromeos).

If all we need this for is BrowserThread (which at a glance appears to be the
case) then we can solve this by either:
a) Use base::MessageLoopProxy::current() if everything is on the same thread,
i.e. the UI thread (see NetworkHander)
b) Use base::WorkerPool if a slow task runner is needed (see ClientCertResolver)
c) pass a TaskRunner to the constructor, setter, or method that needs it, see
TPMTokenLoader, PipeReader, or StatisticsProvider.

https://chromiumcodereview.appspot.com/402403004/diff/40001/chromeos/login/au...
File chromeos/login/auth/online_attempt_host.cc (right):

https://chromiumcodereview.appspot.com/402403004/diff/40001/chromeos/login/au...
chromeos/login/auth/online_attempt_host.cc:13: #include
"content/public/browser/browser_thread.h"
Layering violation.

https://chromiumcodereview.appspot.com/402403004/diff/40001/chromeos/login/au...
File chromeos/login/auth/online_attempt_unittest.cc (right):

https://chromiumcodereview.appspot.com/402403004/diff/40001/chromeos/login/au...
chromeos/login/auth/online_attempt_unittest.cc:18: #include
"content/public/test/test_browser_thread_bundle.h"
Layering violation.

[Denis Kuznetsov (DE-MUC), 2014-07-24 15:22:14]

Please take another look

https://chromiumcodereview.appspot.com/402403004/diff/40001/chromeos/login/au...
File chromeos/login/auth/online_attempt.cc (right):

https://chromiumcodereview.appspot.com/402403004/diff/40001/chromeos/login/au...
chromeos/login/auth/online_attempt.cc:19: #include
"content/public/browser/browser_thread.h"
On 2014/07/22 16:35:37, stevenjb wrote:
> Unfortunately this is a layering violation. src/chromeos is for low-level OS
> code, not content or UI code. (I probably should have named it
> src/system/chromeos).
> 
> If all we need this for is BrowserThread (which at a glance appears to be the
> case) then we can solve this by either:
> a) Use base::MessageLoopProxy::current() if everything is on the same thread,
> i.e. the UI thread (see NetworkHander)
> b) Use base::WorkerPool if a slow task runner is needed (see
ClientCertResolver)
> c) pass a TaskRunner to the constructor, setter, or method that needs it, see
> TPMTokenLoader, PipeReader, or StatisticsProvider.

Done.

https://chromiumcodereview.appspot.com/402403004/diff/40001/chromeos/login/au...
File chromeos/login/auth/online_attempt_host.cc (right):

https://chromiumcodereview.appspot.com/402403004/diff/40001/chromeos/login/au...
chromeos/login/auth/online_attempt_host.cc:13: #include
"content/public/browser/browser_thread.h"
On 2014/07/22 16:35:37, stevenjb wrote:
> Layering violation.

Done.

https://chromiumcodereview.appspot.com/402403004/diff/40001/chromeos/login/au...
File chromeos/login/auth/online_attempt_unittest.cc (right):

https://chromiumcodereview.appspot.com/402403004/diff/40001/chromeos/login/au...
chromeos/login/auth/online_attempt_unittest.cc:18: #include
"content/public/test/test_browser_thread_bundle.h"
On 2014/07/22 16:35:37, stevenjb wrote:
> Layering violation.

Done.

[Nikita (slow), 2014-07-24 15:25:59]

lgtm

https://codereview.chromium.org/402403004/diff/80001/chromeos/login/auth/onli...
File chromeos/login/auth/online_attempt.h (right):

https://codereview.chromium.org/402403004/diff/80001/chromeos/login/auth/onli...
chromeos/login/auth/online_attempt.h:22: namespace content {
not needed

https://codereview.chromium.org/402403004/diff/80001/chromeos/login/auth/onli...
File chromeos/login/auth/online_attempt_host.h (right):

https://codereview.chromium.org/402403004/diff/80001/chromeos/login/auth/onli...
chromeos/login/auth/online_attempt_host.h:18: class BrowserContext;
not needed.

[Denis Kuznetsov (DE-MUC), 2014-07-24 15:48:52]

https://chromiumcodereview.appspot.com/402403004/diff/80001/chromeos/login/au...
File chromeos/login/auth/online_attempt.h (right):

https://chromiumcodereview.appspot.com/402403004/diff/80001/chromeos/login/au...
chromeos/login/auth/online_attempt.h:22: namespace content {
On 2014/07/24 15:25:59, Nikita Kostylev wrote:
> not needed

Done.

https://chromiumcodereview.appspot.com/402403004/diff/80001/chromeos/login/au...
File chromeos/login/auth/online_attempt_host.h (right):

https://chromiumcodereview.appspot.com/402403004/diff/80001/chromeos/login/au...
chromeos/login/auth/online_attempt_host.h:18: class BrowserContext;
On 2014/07/24 15:25:59, Nikita Kostylev wrote:
> not needed.

Done.

[stevenjb, 2014-07-24 16:30:01]

Cheers. LGTM.

[Denis Kuznetsov (DE-MUC), 2014-07-25 11:53:45]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-07-25 11:54:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/402403004/100001

[commit-bot: I haz the power, 2014-07-25 14:37:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[commit-bot: I haz the power, 2014-07-25 14:49:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-25 14:49:54]

Try jobs failed on following builders:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[Nikita (slow), 2014-07-28 09:07:22]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2014-07-28 09:07:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/402403004/100001

[commit-bot: I haz the power, 2014-07-28 12:54:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-07-28 12:57:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-28 12:57:30]

Try jobs failed on following builders:
  linux_chromium_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Denis Kuznetsov (DE-MUC), 2014-08-19 12:39:16]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-08-19 12:39:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/402403004/120001

[commit-bot: I haz the power, 2014-08-19 14:29:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-19 15:50:06]

Committed patchset #7 (120001) as 290562