Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: src/heap.h

Issue 40063002: Bookkeeping for allocation site pretenuring (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebase built on site fields in another CL. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap.h
diff --git a/src/heap.h b/src/heap.h
index 752a1ed73760d0bc92ac0f8586eb05cad6471a47..63955d1f0a1971eea4c507e332720b38b4d62003 100644
--- a/src/heap.h
+++ b/src/heap.h
@@ -1456,6 +1456,13 @@ class Heap {
static inline void ScavengePointer(HeapObject** p);
static inline void ScavengeObject(HeapObject** p, HeapObject* object);
+ // If there is an AllocationMemento after the object, we may need to perform
+ // some extra work.
Hannes Payer (out of office) 2013/11/21 20:52:24 Ambiguous comment, can we be more precise here.
mvstanton 2013/11/22 11:18:51 Thx, I renamed the method to UpdateAllocationSiteF
+ static inline void AddressMemento(HeapObject* object);
+
+ // Commits from space if it is uncommitted.
+ void EnsureFromSpaceIsCommitted();
Hannes Payer (out of office) 2013/11/21 20:52:24 I did not find the reason why this method has to b
mvstanton 2013/11/22 11:18:51 Me neither! fixed.
+
// Support for partial snapshots. After calling this we have a linear
// space to write objects in each space.
void ReserveSpace(int *sizes, Address* addresses);
@@ -2151,9 +2158,6 @@ class Heap {
// Performs a minor collection in new generation.
void Scavenge();
- // Commits from space if it is uncommitted.
- void EnsureFromSpaceIsCommitted();
-
// Uncommit unused semi space.
bool UncommitFromSpace() { return new_space_.UncommitFromSpace(); }

Powered by Google App Engine
This is Rietveld 408576698