Bookkeeping for allocation site pretenuring

src/heap.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1438 matching lines @@
   void TracePathToGlobal();
 #endif
 
   // Callback function passed to Heap::Iterate etc.  Copies an object if
   // necessary, the object might be promoted to an old space.  The caller must
   // ensure the precondition that the object is (a) a heap object and (b) in
   // the heap's from space.
   static inline void ScavengePointer(HeapObject** p);
   static inline void ScavengeObject(HeapObject** p, HeapObject* object);
 
+  // If there is an AllocationMemento after the object, we may need to perform
+  // some extra work.

[Hannes Payer (out of office), 2013/11/21 20:52:24]

Ambiguous comment, can we be more precise here.

[mvstanton, 2013/11/22 11:18:51]

Thx, I renamed the method to UpdateAllocationSiteFeedback to clarify meaning.
I'll keep the comment there because it's the style of heap.h, but modify it a
bit.

+  static inline void AddressMemento(HeapObject* object);
+
+  // Commits from space if it is uncommitted.
+  void EnsureFromSpaceIsCommitted();

[Hannes Payer (out of office), 2013/11/21 20:52:24]

I did not find the reason why this method has to be public.

[mvstanton, 2013/11/22 11:18:51]

Me neither! fixed.

+
   // Support for partial snapshots.  After calling this we have a linear
   // space to write objects in each space.
   void ReserveSpace(int *sizes, Address* addresses);
 
   //
   // Support for the API.
   //
 
   bool CreateApiObjects();
 
@@ skipping 675 matching lines @@
   // Allocate a tenured JS global property cell initialized with the hole.
   MUST_USE_RESULT MaybeObject* AllocatePropertyCell();
 
   // Allocate Box.
   MUST_USE_RESULT MaybeObject* AllocateBox(Object* value,
                                            PretenureFlag pretenure);
 
   // Performs a minor collection in new generation.
   void Scavenge();
 
-  // Commits from space if it is uncommitted.
-  void EnsureFromSpaceIsCommitted();
-
   // Uncommit unused semi space.
   bool UncommitFromSpace() { return new_space_.UncommitFromSpace(); }
 
   // Fill in bogus values in from space
   void ZapFromSpace();
 
   static String* UpdateNewSpaceReferenceInExternalStringTableEntry(
       Heap* heap,
       Object** pointer);
 
@@ skipping 914 matching lines @@
   DisallowHeapAllocation no_allocation;  // i.e. no gc allowed.
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PathTracer);
 };
 #endif  // DEBUG
 
 } }  // namespace v8::internal
 
 #endif  // V8_HEAP_H_