Bypass android download manager if response is not yet received

chrome/browser/android/intercept_download_resource_throttle.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/intercept_download_resource_throttle.h"
 
 #include "components/data_reduction_proxy/common/data_reduction_proxy_headers.h"
 #include "content/public/browser/android/download_controller_android.h"
 #include "content/public/browser/resource_controller.h"
 #include "net/http/http_request_headers.h"
@@ skipping 13 matching lines @@
     : request_(request),
       render_process_id_(render_process_id),
       render_view_id_(render_view_id),
       request_id_(request_id) {
 }
 
 InterceptDownloadResourceThrottle::~InterceptDownloadResourceThrottle() {
 }
 
 void InterceptDownloadResourceThrottle::WillStartRequest(bool* defer) {
   ProcessDownloadRequest();

[asanka, 2014/07/16 16:53:08]

This won't do anything now. WillStartRequest is called before
URLRequest::Start() is called. There won't be URLRequest::Job at that point and
hence GetFullRequestHeaders() returns false.

Also URLRequest::GetMimeType() shouldn't be called before the response is ready
(i.e. at or after WillProcessResponse).

[qinmin, 2014/07/16 17:13:39]

Remove the call to ProcessDownloadRequest here.

On 2014/07/16 16:53:08, asanka wrote:

 }
 
 void InterceptDownloadResourceThrottle::WillProcessResponse(bool* defer) {
   ProcessDownloadRequest();
 }
 
 const char* InterceptDownloadResourceThrottle::GetNameForLogging() const {
   return "InterceptDownloadResourceThrottle";
 }
 
 void InterceptDownloadResourceThrottle::ProcessDownloadRequest() {
   if (request_->url_chain().empty())
     return;
 
   GURL url = request_->url_chain().back();
   if (!url.SchemeIsHTTPOrHTTPS())
     return;
 
   if (request_->method() != net::HttpRequestHeaders::kGetMethod)
     return;
 
+  net::HttpRequestHeaders headers;
+  if (!request_->GetFullRequestHeaders(&headers))
+    return;
+
   // In general, if the request uses HTTP authorization, either with the origin
   // or a proxy, then the network stack should handle the download. The one
   // exception is a request that is fetched via the Chrome Proxy and does not
   // authenticate with the origin.
   if (request_->response_info().did_use_http_auth) {
 #if defined(SPDY_PROXY_AUTH_ORIGIN)
-    net::HttpRequestHeaders headers;
-    request_->GetFullRequestHeaders(&headers);
     if (headers.HasHeader(net::HttpRequestHeaders::kAuthorization) ||
         !(request_->response_info().headers &&
             data_reduction_proxy::HasDataReductionProxyViaHeader(
                 request_->response_info().headers))) {
       return;
     }
 #else
     return;
 #endif
   }
 
   // For OMA DRM downloads, Android Download Manager doesn't handle them
   // correctly. Use chromium network stack instead. http://crbug.com/382698.
   std::string mime;
   const_cast<net::URLRequest*>(request_)->GetMimeType(&mime);

[asanka, 2014/07/16 16:53:08]

Why the const_cast here?

[qinmin, 2014/07/16 17:13:39]

GetMimeType() was recently changed to a const call.
Removed the const_cast keyword.

On 2014/07/16 16:53:08, asanka wrote:

   if (!mime.compare(kOmaDrmContentMime) || !mime.compare(kOmaDrmMessageMime))
     return;
 
   content::DownloadControllerAndroid::Get()->CreateGETDownload(
       render_process_id_, render_view_id_, request_id_);
   controller()->Cancel();
 }
 
 }  // namespace chrome