Docserver: Fix missing samples in some API reference pages

chrome/common/extensions/docs/server2/samples_data_source.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import hashlib
 import json
 import logging
 import posixpath
 import re
 import traceback
@@ skipping 173 matching lines @@
     if accept_language is None:
       return []
     return [lang_with_q.split(';')[0].strip()
             for lang_with_q in accept_language.split(',')]
 
   def FilterSamples(self, key, api_name):
     '''Fetches and filters the list of samples specified by |key|, returning
     only the samples that use the API |api_name|. |key| is either 'apps' or
     'extensions'.
     '''
-    api_search = api_name.replace('.', '_') + '_'
+    api_search = api_name + '.'
     samples_list = []
     try:
       for sample in self.get(key):
-        api_calls_unix = [model.UnixName(call['name'])
-                          for call in sample['api_calls']]
+        api_calls_unix = [call['name'] for call in sample['api_calls']]
         for call in api_calls_unix:
           if call.startswith(api_search):
             samples_list.append(sample)
             break

[not at google - send to devlin, 2013/10/24 20:27:54]

thanks for this fix. It can be much simpler:

try:
  return [call['name'] for call in sample['api_calls']
          if call['name'].startswith(api_name + '.')]
except NotImplementedError:
  return []

though that bug looks fixed; maybe you don't need the try/except either.

[方觉(Fang Jue), 2013/10/25 00:59:46]

It's not actually correct but I got what you meant. I inlined everything as a
single return statement.
It is fixed. I also looked at other files and it seems that NotImplementedError
shouldn't be raised here so I removed the try/except.

     except NotImplementedError:
       # If we're testing, the GithubFileSystem can't fetch samples.
       # Bug: http://crbug.com/141910
       return []
     return samples_list
 
   def _CreateSamplesDict(self, key):
     if key == 'apps':
       samples_list = self._apps_cache.GetFromFileListing('/').Get()
     else:
@@ skipping 28 matching lines @@
       else:
         dict_['id'] = self._GetSampleId(name)
         return_list.append(dict_)
     return return_list
 
   def get(self, key):
     return {
       'apps': lambda: self._CreateSamplesDict('apps'),
       'extensions': lambda: self._CreateSamplesDict('extensions')
     }.get(key, lambda: {})()