Add VM class for Map/LinkedHashMap.

runtime/vm/raw_object_snapshot.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bigint_operations.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/snapshot.h"
 #include "vm/stub_code.h"
 #include "vm/symbols.h"
@@ skipping 2154 matching lines @@
   writer->WriteTags(writer->GetObjectTags(this));
 
   // Write out the used length field.
   writer->Write<RawObject*>(ptr()->length_);
 
   // Write out the Array object.
   writer->WriteObjectImpl(ptr()->data_);
 }
 
 
+RawLinkedHashMap* LinkedHashMap::ReadFrom(SnapshotReader* reader,
+                                              intptr_t object_id,
+                                              intptr_t tags,
+                                              Snapshot::Kind kind) {
+  ASSERT(reader != NULL);
+
+  LinkedHashMap& map = LinkedHashMap::ZoneHandle(
+      reader->isolate(), LinkedHashMap::null());
+  if (kind == Snapshot::kFull) {

[siva, 2014/07/23 22:43:07]

Do we expect to see hash maps in script snapshots?

[koda, 2014/07/24 19:31:44]

In the future, yes. But not currently, the immutable maps that seed map literals
are not yet VM-internal.

I added the script case and a comment both here and in WriteTo.

+    UNREACHABLE();
+  } else {
+    map = LinkedHashMap::New(HEAP_SPACE(kind));
+  }
+  reader->AddBackRef(object_id, &map, kIsDeserialized);
+  Array& contents = Array::Handle();

[siva, 2014/07/23 22:43:07]

Array::Handle(reader->isolate());

[koda, 2014/07/24 19:31:44]

Done, also in GrowableObjectArray above.

+  contents ^= reader->ReadObjectImpl();
+  map.SetData(contents);
+  const TypeArguments& type_arguments =
+      TypeArguments::Handle(contents.GetTypeArguments());

[siva, 2014/07/23 22:43:07]

TypeArguments::Handle(reader->isolate(), ...);

[koda, 2014/07/24 19:31:44]

Done, also in GrowableObjectArray above.

+  map.SetTypeArguments(type_arguments);
+  return map.raw();
+}
+
+
+void RawLinkedHashMap::WriteTo(SnapshotWriter* writer,
+                                 intptr_t object_id,
+                                 Snapshot::Kind kind) {

[siva, 2014/07/23 22:43:07]

if (kind == Snapshot::kFull) UNREACHABLE() ?
Also what about script snapshots?

[koda, 2014/07/24 19:31:44]

See previous comment.

+  ASSERT(writer != NULL);
+
+  // Write out the serialization header value for this object.
+  writer->WriteInlinedObjectHeader(object_id);
+
+  // Write out the class and tags information.
+  writer->WriteIndexedObject(kLinkedHashMapCid);
+  writer->WriteTags(writer->GetObjectTags(this));
+
+  // Write out the backing array.
+  // TODO(koda): Serialize as pairs (like ToArray) instead, to reduce space and
+  // support per-isolate salted hash codes.
+  writer->WriteObjectImpl(ptr()->data_);
+}
+
+
 RawFloat32x4* Float32x4::ReadFrom(SnapshotReader* reader,
                                   intptr_t object_id,
                                   intptr_t tags,
                                   Snapshot::Kind kind) {
   ASSERT(reader != NULL);
   // Read the values.
   float value0 = reader->Read<float>();
   float value1 = reader->Read<float>();
   float value2 = reader->Read<float>();
   float value3 = reader->Read<float>();
@@ skipping 614 matching lines @@
     // We do not allow objects with native fields in an isolate message.
     writer->SetWriteException(Exceptions::kArgument,
                               "Illegal argument in isolate message"
                               " : (object is a UserTag)");
   } else {
     UNREACHABLE();
   }
 }
 
 }  // namespace dart