Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6824)

Unified Diff: content/browser/frame_host/navigator.h

Issue 379143002: PlzNavigate: implement RequestNavigation in the no live renderer case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed speculative rfh + no pending_navigation_entry dependency Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index 39345f47e4950110ca947a5c911ab90c6ffbec41..0a1d9b85f6ceadf63a42b38a0f5f918e975b074c 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -11,6 +11,7 @@
#include "ui/base/window_open_disposition.h"
class GURL;
+struct FrameHostMsg_BeginNavigation_Params;
struct FrameHostMsg_DidCommitProvisionalLoad_Params;
struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;
@@ -24,6 +25,7 @@ class NavigationControllerImpl;
class NavigationEntryImpl;
class NavigatorDelegate;
class RenderFrameHostImpl;
+struct NavigationBeforeCommitInfo;
// Implementations of this interface are responsible for performing navigations
// in a node of the FrameTree. Its lifetime is bound to all FrameTreeNode
@@ -37,7 +39,6 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
// Returns the NavigationController associated with this Navigator.
virtual NavigationController* GetController();
-
// Notifications coming from the RenderFrameHosts ----------------------------
// The RenderFrameHostImpl started a provisional load.
@@ -119,6 +120,20 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
bool should_replace_current_entry,
bool user_gesture) {}
+ // PlzNavigate
+ // Called after receiving a FrameHostMsg_BeginNavigation IPC from the
+ // renderer. Will create a NavigationEntry for the navigation and pass it to
+ // the RenderFrameHostManager, that will dispatch a NavigationRequest to the
+ // IO thread.
+ virtual void OnBeginNavigation(
+ RenderFrameHostImpl* render_frame_host,
+ const FrameHostMsg_BeginNavigation_Params& params) {};
+
+ // PlzNavigate
+ // Commit the navigation in the |render_frame_host|.
Charlie Reis 2014/08/08 20:25:27 See my request on RFHM::CommitPending about a more
clamy 2014/08/12 12:13:15 Done.
+ virtual void CommitNavigation(RenderFrameHostImpl* render_frame_host,
+ const NavigationBeforeCommitInfo& info) {};
+
protected:
friend class base::RefCounted<Navigator>;
virtual ~Navigator() {}

Powered by Google App Engine
This is Rietveld 408576698