content/browser/web_contents/web_contents_impl.cc - Issue 379143002: PlzNavigate: implement RequestNavigation in the no live renderer case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 379143002: PlzNavigate: implement RequestNavigation in the no live renderer case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Charlie's comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_manager.cc ('K') | « content/browser/frame_host/render_frame_host_manager_unittest.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 9c40100612d6022542c28706a618ade5f8abd5e0..0623941936003b54327125c3ee10aaa8661bdb2b 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -3860,7 +3860,7 @@ WebPreferences WebContentsImpl::GetWebkitPrefs() {

int WebContentsImpl::CreateSwappedOutRenderView(

SiteInstance* instance) {

return GetRenderManager()->CreateRenderFrame(instance, MSG_ROUTING_NONE,

- true, true);

+ true, true, false);

}

void WebContentsImpl::OnUserGesture() {

@@ -4031,7 +4031,7 @@ int WebContentsImpl::CreateOpenerRenderViews(SiteInstance* instance) {

// Create a swapped out RenderView in the given SiteInstance if none exists,

// setting its opener to the given route_id. Return the new view's route_id.

return GetRenderManager()->CreateRenderFrame(instance, opener_route_id,

- true, true);

+ true, true, false);

}

NavigationControllerImpl& WebContentsImpl::GetControllerForRenderManager() {