Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1548)

Unified Diff: content/browser/frame_host/navigation_commit_info.h

Issue 379143002: PlzNavigate: implement RequestNavigation in the no live renderer case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Nasko's comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_commit_info.h
diff --git a/content/browser/frame_host/navigation_commit_info.h b/content/browser/frame_host/navigation_commit_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..2b598c6afd78d0e6e5433e87b33aa11ca24881c2
--- /dev/null
+++ b/content/browser/frame_host/navigation_commit_info.h
@@ -0,0 +1,40 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_COMMIT_INFO_H_
+#define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_COMMIT_INFO_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "content/public/common/page_transition_types.h"
+#include "content/public/common/referrer.h"
+#include "url/gurl.h"
+
+namespace content {
+
+// Holds the parameters determined during the load of a navigation request
Charlie Reis 2014/07/29 17:46:56 Sounds like this is mainly for the time before com
clamy 2014/07/30 13:10:24 I renamed it NavigationBeforeCommitInfo. Is that b
+// until receiving the response. Initialized on the IO thread, then passed to
+// the UI thread where it should be used to send a FrameMsg_CommitNavigation
+// message to the renderer.
+struct NavigationCommitInfo {
+ NavigationCommitInfo() {};
+
+ // The url that is actually being loaded.
+ GURL navigation_url;
+
+ // A url to be subsequently requested by the renderer as the main resource for
+ // the frame, that will be used to find the associated stream of data.
+ GURL content_url;
Charlie Reis 2014/07/29 17:46:56 I don't understand what this is for. 1) I thought
clamy 2014/07/30 13:10:24 We are using the blob url construct to request the
+
+ // TODO(clamy): Maybe add the redirect chain if needed by the renderer.
+
+ // The navigationStart time to expose to JS for this navigation.
+ // TODO(clamy): Add the other values that matter to the Navigation Timing API.
+ base::TimeTicks browser_navigation_start;
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_COMMIT_INFO_H_
« no previous file with comments | « no previous file | content/browser/frame_host/navigator.h » ('j') | content/browser/frame_host/render_frame_host_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698