PlzNavigate: implement RequestNavigation in the no live renderer case

content/browser/frame_host/render_frame_host_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_path.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/time/time.h"
 #include "content/browser/frame_host/cross_site_transferring_request.h"
 #include "content/browser/frame_host/navigation_controller_impl.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
 #include "content/browser/frame_host/navigation_request.h"
 #include "content/browser/frame_host/navigator.h"
+#include "content/browser/frame_host/navigator_impl.h"
 #include "content/browser/frame_host/render_frame_host_manager.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/browser/webui/web_ui_controller_factory_registry.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_widget_host_iterator.h"
@@ skipping 1862 matching lines @@
   NavigationRequest* main_request =
       NavigationRequestForRenderFrameManager(
         main_test_rfh()->frame_tree_node()->render_manager());
   ASSERT_TRUE(main_request);
   EXPECT_EQ(kUrl3, main_request->info_for_testing().navigation_params.url);
   EXPECT_EQ(kUrl3, main_request->info_for_testing().first_party_for_cookies);
   EXPECT_TRUE(main_request->info_for_testing().is_main_frame);
   EXPECT_FALSE(main_request->info_for_testing().parent_is_main_frame);
 }
 
+// Browser side navigation: Test that RequestNavigation creates a
+// NavigationRequest and that a RenderFrameHost is initialized to handle the
+// request when it commits.
+TEST_F(RenderFrameHostManagerTest,
+       BrowserSideNavigationRequestNavigationNoLiveRenderer) {
+  const GURL kUrl("http://www.google.com/");
+
+  EXPECT_FALSE(main_test_rfh()->render_view_host()->IsRenderViewLive());
+  NavigationEntryImpl entry = NavigationEntryImpl(
+      NULL, 0, kUrl, Referrer(), base::string16(), PAGE_TRANSITION_LINK, false);
+  FrameMsg_Navigate_Params navigate_params;
+  NavigatorImpl::MakeNavigateParams(
+      entry,
+      contents()->GetController(),
+      NavigationController::NO_RELOAD,
+      base::TimeTicks::Now(),
+      &navigate_params);
+  main_test_rfh()->frame_tree_node()->render_manager()->RequestNavigation(
+      entry, navigate_params);
+  NavigationRequest* main_request =
+      NavigationRequestForRenderFrameManager(
+        main_test_rfh()->frame_tree_node()->render_manager());
+  // A NavigationRequest should have been generated.
+  EXPECT_TRUE(main_request);

[nasko, 2014/07/17 12:05:08]

main_request is a pointer, not boolean. Use EXPECT_EQ or if using EXPECT_TRUE,
use a comparison to NULL.

[clamy, 2014/07/17 13:07:53]

Done.

+  // The RFH should have been initialized to handle the navigation when it
+  // commits.
+  EXPECT_TRUE(main_test_rfh()->render_view_host()->IsRenderViewLive());

[nasko, 2014/07/17 12:05:08]

Shouldn't the main RFH also be the speculative RFH?

[clamy, 2014/07/17 13:07:53]

The speculative RFH cannot be the main RFH. The speculative RFH is only spawned
when the site instance for the navigation is different from the one for the main
RFH. If they are the same, then the current RFH is initialized, and no extra RFH
is created.

+}
+
 }  // namespace content