PlzNavigate: implement RequestNavigation in the no live renderer case

content/browser/frame_host/navigation_request.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
+#include "content/browser/frame_host/navigation_entry_impl.h"
 #include "content/browser/frame_host/navigation_request_info.h"
 
 namespace content {
 class ResourceRequestBody;
 
 // A UI thread object that owns a navigation request until it commits. It

[Charlie Reis, 2014/08/08 20:25:27]

Is this class just for PlzNavigate?  If so, let's add a // PlzNavigate comment.

[clamy, 2014/08/12 12:13:15]

Done.

 // ensures the UI thread can start a navigation request in the
 // ResourceDispatcherHost (that lives on the IO thread).
 // TODO(clamy): Describe the interactions between the UI and IO thread during
 // the navigation following its refactoring.
 class NavigationRequest {
  public:
-  NavigationRequest(const NavigationRequestInfo& info, int64 frame_node_id);
+  NavigationRequest(const NavigationRequestInfo& info,
+                    const NavigationEntryImpl& entry,
+                    int64 frame_node_id);
 
   ~NavigationRequest();
 
   const NavigationRequestInfo& info_for_testing() const { return info_; }
+  const NavigationEntryImpl& entry() const { return entry_; }
   int64 frame_node_id() const { return frame_node_id_; }
 
   // Called on the UI thread by the RenderFrameHostManager which owns the
   // NavigationRequest. After calling this function, |body| can no longer be
   // manipulated on the UI thread.
   void BeginNavigation(scoped_refptr<ResourceRequestBody> body);
 
+  // Change the url of entry_ to |final_url|, that the url the browser navigated
+  // to after the chain of redirects.
+  void UpdateEntryForCommit(const GURL& final_url);
+
  private:
   const NavigationRequestInfo info_;
+  NavigationEntryImpl entry_;

[clamy, 2014/08/08 12:02:46]

I am currently storing the NavigationEntry we need for CommitNavigation here,
but I don't think it is very optimal (since we end up doing a copy of it).
Another option would be to store it in the navigator. Wdyt?

[Charlie Reis, 2014/08/08 20:25:27]

Yeah, we can't store a copy because NavigationEntries are mutable.  I'm not sure
we need to store it at all.

[clamy, 2014/08/12 12:13:15]

We need a navigation entry inside CommitNavigation. I don't really see how to
have one unless it is stored somewhere.

   const int64 frame_node_id_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationRequest);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_