Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: chrome/browser/ui/android/chrome_http_auth_handler.h

Issue 378633002: Upstream support for basic Http authentication. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/tab_android.cc ('k') | chrome/browser/ui/android/chrome_http_auth_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/android/chrome_http_auth_handler.h
diff --git a/chrome/browser/ui/android/chrome_http_auth_handler.h b/chrome/browser/ui/android/chrome_http_auth_handler.h
index b5c52c7e8604fb97f7eab950b2b0214b2c102667..12b582a2584aa3b7af282d58db5dd28dda979d9e 100644
--- a/chrome/browser/ui/android/chrome_http_auth_handler.h
+++ b/chrome/browser/ui/android/chrome_http_auth_handler.h
@@ -17,7 +17,7 @@
// by, e.g., showing the user a login dialog.
class ChromeHttpAuthHandler {
public:
- ChromeHttpAuthHandler(const base::string16& explanation);
+ explicit ChromeHttpAuthHandler(const base::string16& explanation);
~ChromeHttpAuthHandler();
// This must be called before using the object.
@@ -28,10 +28,8 @@ class ChromeHttpAuthHandler {
// are called. |observer| may be NULL in which case the callbacks are skipped.
void SetObserver(LoginHandler* observer);
- // Returns a reference to the Java land ChromeHttpAuthHandler. This
- // reference must not be released, and remains valid until the native
- // ChromeHttpAuthHandler is destructed.
- jobject GetJavaObject();
+ // Show the dialog prompting for login credentials.
+ void ShowDialog(jobject window_android);
// Forwards the autofill data to the Java land object.
void OnAutofillDataAvailable(
« no previous file with comments | « chrome/browser/android/tab_android.cc ('k') | chrome/browser/ui/android/chrome_http_auth_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698