Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeHttpAuthHandler.java

Issue 378633002: Upstream support for basic Http authentication. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix indentation Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeHttpAuthHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeHttpAuthHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeHttpAuthHandler.java
index b20649a7e35d0728e3140e8730ba4a65965dc2ba..6f037ec20b3a0de512b3702699ce840eb926c276 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeHttpAuthHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeHttpAuthHandler.java
@@ -4,7 +4,10 @@
package org.chromium.chrome.browser;
+import android.app.Activity;
+
import org.chromium.base.CalledByNative;
+import org.chromium.ui.base.WindowAndroid;
/**
* Represents an HTTP authentication request to be handled by the UI.
@@ -83,6 +86,20 @@ public class ChromeHttpAuthHandler {
return nativeGetCancelButtonText(mNativeChromeHttpAuthHandler);
}
+ @CalledByNative
+ private void showDialog(WindowAndroid windowAndroid) {
+ if (windowAndroid == null) {
+ cancel();
+ }
+ Activity activity = windowAndroid.getActivity().get();
+ if (activity == null) {
+ cancel();
+ }
+ LoginPrompt authDialog = new LoginPrompt(activity, this);
+ setAutofillObserver(authDialog);
+ authDialog.show();
+ }
+
// ---------------------------------------------
// Autofill-related
// ---------------------------------------------
@@ -101,7 +118,7 @@ public class ChromeHttpAuthHandler {
* Register for onAutofillDataAvailable callbacks. |observer| can be null,
* in which case no callback is made.
*/
- public void setAutofillObserver(AutofillObserver observer) {
+ private void setAutofillObserver(AutofillObserver observer) {
mAutofillObserver = observer;
// In case the autofill data arrives before the observer is set.
if (mAutofillUsername != null && mAutofillPassword != null) {

Powered by Google App Engine
This is Rietveld 408576698