tools/metrics/histograms/histograms.xml - Issue 378063002: Adding cache hit/miss histograms to DiskBasedCertCache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 378063002: Adding cache hit/miss histograms to DiskBasedCertCache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@DBCC_MRU_Implement

Patch Set: Corruption no longer counted as a DiskCache hit, now counted separately. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index e35ae92e0c9f08a2a52273a11e3c56362403f57b..fa989db3fd62aa3492f0447635e39b87c90e3927 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -3499,6 +3499,13 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="DiskBasedCertCache.CertIoCacheResult" enum="CacheResult">

wtc 2014/07/10 18:21:38 Nit: what does the "Io" mean in the histogram name

brandonsalmon 2014/07/10 18:42:39 Oops missed this comment. I did this because Jim r

+ <owner>brandonsalmon@chromium.org</owner>

+ <summary>

+ Measures the frequency of cache hits in the DiskBasedCertCache.

wtc 2014/07/10 18:21:38 This summary needs updating. This histogram is not

+ </summary>

+</histogram>

<owner>rvargas@chromium.org</owner>

<summary>The age of the cache's files (wall time).</summary>

@@ -35319,6 +35326,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</enum>

+<enum name="CacheResult" type="int">

+ <int value="0" label="MEMORY_CACHE_HIT"/>

+ <int value="1" label="DISK_CACHE_HIT"/>

+ <int value="2" label="DISK_CACHE_CORRUPT"/>

+ <int value="3" label="CACHE_MISS"/>

+ <int value="4" label="CACHE_ERROR"/>

+</enum>

« net/http/disk_based_cert_cache.cc ('K') | « net/http/disk_based_cert_cache.cc ('k') | no next file » | no next file with comments »