Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/browser/chrome_content_browser_client.h

Issue 376253005: Migrate the notification permission to the new common permission classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.h
diff --git a/chrome/browser/chrome_content_browser_client.h b/chrome/browser/chrome_content_browser_client.h
index 1b9b1e841848afb0c0e2227394fed4114f8519ec..ff7ca087b7e5e297ca46bbaa6f7e382884e5cd75 100644
--- a/chrome/browser/chrome_content_browser_client.h
+++ b/chrome/browser/chrome_content_browser_client.h
@@ -12,6 +12,7 @@
#include "base/compiler_specific.h"
#include "base/gtest_prod_util.h"
+#include "base/memory/weak_ptr.h"
#include "chrome/common/chrome_version_info.h"
#include "content/public/browser/content_browser_client.h"
@@ -295,6 +296,11 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {
#endif
private:
+ // Used as a callback once a permission has been decided.
+ // TODO(peter) remove once the notification callback returns
+ // a boolean.
+ void NotificationPermissionRequested(base::Closure callback, bool result);
Peter Beverloo 2014/07/18 10:42:38 NotificationPermissionRequested doesn't modify |th
Peter Beverloo 2014/07/18 10:42:38 const base::Closure&
Miguel Garcia 2014/07/18 12:27:08 Done.
Miguel Garcia 2014/07/18 12:27:08 Acknowledged.
+
#if defined(ENABLE_WEBRTC)
// Copies disable WebRTC encryption switch depending on the channel.
static void MaybeCopyDisableWebRtcEncryptionSwitch(
@@ -344,7 +350,8 @@ static void RequestFileSystemPermissionOnUIThread(
// created. It is used only the IO thread.
prerender::PrerenderTracker* prerender_tracker_;
- base::WeakPtrFactory<ChromeContentBrowserClient> weak_factory_;
+ // TODO(peter) remove once NotificationPermissionRequested is removed.
+ base::WeakPtrFactory<ChromeContentBrowserClient> weak_factory_;
friend class DisableWebRtcEncryptionFlagTest;
« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client.cc » ('j') | chrome/browser/chrome_content_browser_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698