Index: chrome/browser/content_settings/permission_context_uma_util.cc |
diff --git a/chrome/browser/content_settings/permission_context_uma_util.cc b/chrome/browser/content_settings/permission_context_uma_util.cc |
index 92da0223fd85e464dceed1bc830cb21024cbde44..2b7ff8f18f6d8c071bba34f6ffa245493b4fe91e 100644 |
--- a/chrome/browser/content_settings/permission_context_uma_util.cc |
+++ b/chrome/browser/content_settings/permission_context_uma_util.cc |
@@ -24,18 +24,15 @@ enum PermissionAction { |
// permission actions. Never delete or reorder an entry; only add new entries |
// immediately before PERMISSION_NUM |
enum PermissionType { |
- PERMISSION_UNKNOWN, |
- PERMISSION_MIDI_SYSEX, |
- PERMISSION_PUSH_MESSAGING, |
+ PERMISSION_UNKNOWN = 0, |
+ PERMISSION_MIDI_SYSEX = 1, |
+ PERMISSION_PUSH_MESSAGING = 2, |
+ PERMISSION_NOTIFICATIONS = 3, |
// Always keep this at the end. |
PERMISSION_NUM, |
}; |
-static const char* kMidiUmaKey = "ContentSettings.PermisionActions_MidiSysEx"; |
-static const char* kPushMessageUmaKey = |
- "ContentSettings.PermisionActions_PushMessaging"; |
- |
void RecordPermissionAction( |
ContentSettingsType permission, PermissionAction action) { |
switch (permission) { |
@@ -43,15 +40,22 @@ void RecordPermissionAction( |
// TODO(miguelg): support geolocation through |
// the generic permission class. |
break; |
+ case CONTENT_SETTINGS_TYPE_NOTIFICATIONS: |
+ UMA_HISTOGRAM_ENUMERATION( |
+ "ContentSettings.PermisionActions_Notifications", |
+ action, |
+ PERMISSION_ACTION_NUM); |
+ break; |
case CONTENT_SETTINGS_TYPE_MIDI_SYSEX: |
- UMA_HISTOGRAM_ENUMERATION(kMidiUmaKey, |
+ UMA_HISTOGRAM_ENUMERATION("ContentSettings.PermisionActions_MidiSysEx", |
action, |
PERMISSION_ACTION_NUM); |
break; |
case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING: |
- UMA_HISTOGRAM_ENUMERATION(kPushMessageUmaKey, |
- action, |
- PERMISSION_ACTION_NUM); |
+ UMA_HISTOGRAM_ENUMERATION( |
+ "ContentSettings.PermisionActions_PushMessaging", |
+ action, |
+ PERMISSION_ACTION_NUM); |
break; |
#if defined(OS_ANDROID) |
case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER: |
@@ -68,6 +72,9 @@ void RecordPermissionRequest( |
ContentSettingsType permission) { |
PermissionType type; |
switch (permission) { |
+ case CONTENT_SETTINGS_TYPE_NOTIFICATIONS: |
+ type = PERMISSION_NOTIFICATIONS; |
+ break; |
case CONTENT_SETTINGS_TYPE_MIDI_SYSEX: |
type = PERMISSION_MIDI_SYSEX; |
break; |