Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: Source/core/frame/FrameConsole.h

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/TouchEvent.cpp ('k') | Source/core/frame/FrameConsole.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/FrameConsole.h
diff --git a/Source/core/frame/FrameConsole.h b/Source/core/frame/FrameConsole.h
index 61e841f359413dfc2c3b1f06e822b8586eb598c9..4541ef6cb1232704a9d7fdd45ee46a5fae430d29 100644
--- a/Source/core/frame/FrameConsole.h
+++ b/Source/core/frame/FrameConsole.h
@@ -31,13 +31,14 @@
#include "bindings/core/v8/ScriptState.h"
#include "core/frame/ConsoleTypes.h"
-#include "core/inspector/ScriptCallStack.h"
#include "wtf/Forward.h"
#include "wtf/PassOwnPtr.h"
namespace blink {
+class ConsoleMessage;
class FrameHost;
+class ScriptCallStack;
// FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector.
// It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console.
@@ -45,9 +46,7 @@ class FrameConsole FINAL {
public:
static PassOwnPtr<FrameConsole> create(LocalFrame& frame) { return adoptPtr(new FrameConsole(frame)); }
- void addMessage(MessageSource, MessageLevel, const String& message);
- void addMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, unsigned columnNumber = 0, PassRefPtrWillBeRawPtr<ScriptCallStack> = nullptr, ScriptState* = 0, unsigned long requestIdentifier = 0);
- void addMessage(MessageSource, MessageLevel, const String& message, PassRefPtrWillBeRawPtr<ScriptCallStack>);
+ void addMessage(PassRefPtr<ConsoleMessage>);
static String formatStackTraceString(const String& originalMessage, PassRefPtrWillBeRawPtr<ScriptCallStack>);
static void mute();
« no previous file with comments | « Source/core/events/TouchEvent.cpp ('k') | Source/core/frame/FrameConsole.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698