Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: Source/core/dom/Document.cpp

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/parser/BisonCSSParser-in.cpp ('k') | Source/core/events/TouchEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index fa34137a4151ac03364e5c186e70df7080798a5e..fd82124072de0bad419ae7e1956827102d3c6b6a 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -150,6 +150,7 @@
#include "core/html/parser/HTMLParserIdioms.h"
#include "core/html/parser/NestingLevelIncrementer.h"
#include "core/html/parser/TextResourceDecoder.h"
+#include "core/inspector/ConsoleMessage.h"
#include "core/inspector/InspectorCounters.h"
#include "core/inspector/InspectorInstrumentation.h"
#include "core/inspector/InspectorTraceEvents.h"
@@ -5024,7 +5025,10 @@ void Document::internalAddMessage(MessageSource source, MessageLevel level, cons
lineNumber = parser->lineNumber().oneBasedInt();
}
}
- m_frame->console().addMessage(source, level, message, messageURL, lineNumber, 0, callStack, scriptState, 0);
+ RefPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(source, level, message, messageURL, lineNumber);
+ consoleMessage->setCallStack(callStack);
+ consoleMessage->setScriptState(scriptState);
+ m_frame->console().addMessage(consoleMessage.release());
}
void Document::addConsoleMessageWithRequestIdentifier(MessageSource source, MessageLevel level, const String& message, unsigned long requestIdentifier)
@@ -5034,8 +5038,11 @@ void Document::addConsoleMessageWithRequestIdentifier(MessageSource source, Mess
return;
}
- if (m_frame)
- m_frame->console().addMessage(source, level, message, String(), 0, 0, nullptr, 0, requestIdentifier);
+ if (m_frame) {
+ RefPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(source, level, message);
+ consoleMessage->setRequestIdentifier(requestIdentifier);
+ m_frame->console().addMessage(consoleMessage.release());
+ }
}
// FIXME(crbug.com/305497): This should be removed after ExecutionContext-LocalDOMWindow migration.
« no previous file with comments | « Source/core/css/parser/BisonCSSParser-in.cpp ('k') | Source/core/events/TouchEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698