Source/core/frame/UseCounter.cpp - Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/UseCounter.cpp

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/FrameConsole.cpp ('K') | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/core/inspector/ConsoleMessage.h » ('j') | Source/core/inspector/InspectorConsoleAgent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/UseCounter.cpp

diff --git a/Source/core/frame/UseCounter.cpp b/Source/core/frame/UseCounter.cpp

index ff015350d4eb0393e32523b5c1acbdf53c44c96d..764140188a025fbf33ea623d50f39638dd01b2cc 100644

--- a/Source/core/frame/UseCounter.cpp

+++ b/Source/core/frame/UseCounter.cpp

@@ -35,6 +35,7 @@

#include "core/frame/FrameConsole.h"

#include "core/frame/FrameHost.h"

#include "core/frame/LocalFrame.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/workers/WorkerGlobalScope.h"

#include "public/platform/Platform.h"

@@ -634,7 +635,7 @@ void UseCounter::countDeprecation(const Document& document, Feature feature)

if (host->useCounter().recordMeasurement(feature)) {

ASSERT(!host->useCounter().deprecationMessage(feature).isEmpty());

- frame->console().addMessage(DeprecationMessageSource, WarningMessageLevel, host->useCounter().deprecationMessage(feature));

+ frame->console().addMessage(ConsoleMessage::create(DeprecationMessageSource, WarningMessageLevel, host->useCounter().deprecationMessage(feature)));

}

« Source/core/frame/FrameConsole.cpp ('K') | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/core/inspector/ConsoleMessage.h » ('j') | Source/core/inspector/InspectorConsoleAgent.h » ('J')