Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1994)

Unified Diff: Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/ServiceWorkerGlobalScopeProxy.cpp
diff --git a/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/Source/web/ServiceWorkerGlobalScopeProxy.cpp
index f87bdefde6edc1f30d9d4e85a8ce65d90f42c023..8a815c8bb4273a27f66372dfd77ded54aa5205ff 100644
--- a/Source/web/ServiceWorkerGlobalScopeProxy.cpp
+++ b/Source/web/ServiceWorkerGlobalScopeProxy.cpp
@@ -36,6 +36,7 @@
#include "core/dom/ExecutionContext.h"
#include "core/dom/MessagePort.h"
#include "core/events/MessageEvent.h"
+#include "core/inspector/ConsoleMessage.h"
#include "core/workers/WorkerGlobalScope.h"
#include "modules/push_messaging/PushEvent.h"
#include "modules/serviceworkers/FetchEvent.h"
@@ -114,9 +115,9 @@ void ServiceWorkerGlobalScopeProxy::dispatchSyncEvent(int eventID)
ServiceWorkerGlobalScopeClient::from(m_workerGlobalScope)->didHandleSyncEvent(eventID);
}
-void ServiceWorkerGlobalScopeProxy::reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL)
+void ServiceWorkerGlobalScopeProxy::reportException(PassRefPtr<ConsoleMessage> consoleMessage)
{
- m_client.reportException(errorMessage, lineNumber, columnNumber, sourceURL);
+ m_client.reportException(consoleMessage->message(), consoleMessage->lineNumber(), consoleMessage->columnNumber(), consoleMessage->url());
}
void ServiceWorkerGlobalScopeProxy::reportConsoleMessage(MessageSource source, MessageLevel level, const String& message, int lineNumber, const String& sourceURL)

Powered by Google App Engine
This is Rietveld 408576698