Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: Source/core/inspector/InspectorConsoleAgent.h

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorConsoleAgent.h
diff --git a/Source/core/inspector/InspectorConsoleAgent.h b/Source/core/inspector/InspectorConsoleAgent.h
index 676133f89880337eadb62055b8b5a7239dd3bc84..2ddfc34bf1c60ae3da09a9ddd13b2114105da467 100644
--- a/Source/core/inspector/InspectorConsoleAgent.h
+++ b/Source/core/inspector/InspectorConsoleAgent.h
@@ -44,6 +44,7 @@ class ConsoleMessage;
class DocumentLoader;
class LocalDOMWindow;
class LocalFrame;
+class InspectorConsoleMessage;
class InspectorFrontend;
class InjectedScriptManager;
class InspectorTimelineAgent;
@@ -76,11 +77,8 @@ public:
virtual void clearFrontend() OVERRIDE FINAL;
virtual void restore() OVERRIDE FINAL;
+ void addMessageToConsole(PassRefPtr<ConsoleMessage>);
void addMessageToConsole(MessageSource, MessageType, MessageLevel, const String& message, ScriptState*, PassRefPtrWillBeRawPtr<ScriptArguments>, unsigned long requestIdentifier = 0);
- void addMessageToConsole(MessageSource, MessageType, MessageLevel, const String& message, const String& scriptId, unsigned lineNumber, unsigned columnNumber = 0, ScriptState* = 0, unsigned long requestIdentifier = 0);
-
- // FIXME: Remove once we no longer generate stacks outside of Inspector.
- void addMessageToConsole(MessageSource, MessageType, MessageLevel, const String& message, PassRefPtrWillBeRawPtr<ScriptCallStack>, unsigned long requestIdentifier = 0);
Vector<unsigned> consoleMessageArgumentCounts();
@@ -106,12 +104,12 @@ public:
virtual bool isWorkerAgent() = 0;
protected:
- void addConsoleMessage(PassOwnPtr<ConsoleMessage>);
+ void addConsoleMessage(PassOwnPtr<InspectorConsoleMessage>);
InspectorTimelineAgent* m_timelineAgent;
InjectedScriptManager* m_injectedScriptManager;
InspectorFrontend::Console* m_frontend;
- Vector<OwnPtr<ConsoleMessage> > m_consoleMessages;
+ Vector<OwnPtr<InspectorConsoleMessage> > m_consoleMessages;
int m_expiredConsoleMessageCount;
HashCountedSet<String> m_counts;
HashMap<String, double> m_times;

Powered by Google App Engine
This is Rietveld 408576698