Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: Source/core/dom/Document.h

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index 68fd2fa035b76ca0bdf4a49546a62975c8e83ced..1453849182898b33d5891f64980279de997c424e 100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -934,7 +934,7 @@ public:
void serviceScriptedAnimations(double monotonicAnimationStartTime);
virtual EventTarget* errorEventTarget() OVERRIDE FINAL;
- virtual void logExceptionToConsole(const String& errorMessage, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack>) OVERRIDE FINAL;
+ virtual void logExceptionToConsole(PassRefPtr<ConsoleMessage>) OVERRIDE FINAL;
void initDNSPrefetch();
@@ -999,7 +999,7 @@ public:
void didAssociateFormControl(Element*);
- void addConsoleMessageWithRequestIdentifier(MessageSource, MessageLevel, const String& message, unsigned long requestIdentifier);
+ void addConsoleMessageWithRequestIdentifier(PassRefPtr<ConsoleMessage>);
virtual LocalDOMWindow* executingWindow() OVERRIDE FINAL;
LocalFrame* executingFrame();
@@ -1098,8 +1098,8 @@ private:
virtual KURL virtualCompleteURL(const String&) const OVERRIDE FINAL; // Same as completeURL() for the same reason as above.
virtual void reportBlockedScriptExecutionToInspector(const String& directiveText) OVERRIDE FINAL;
- virtual void addMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, ScriptState*) OVERRIDE FINAL;
- void internalAddMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, PassRefPtrWillBeRawPtr<ScriptCallStack>, ScriptState*);
+ virtual void addMessage(PassRefPtr<ConsoleMessage>) OVERRIDE FINAL;
+ void internalAddMessage(PassRefPtr<ConsoleMessage>);
virtual double timerAlignmentInterval() const OVERRIDE FINAL;

Powered by Google App Engine
This is Rietveld 408576698